-
Notifications
You must be signed in to change notification settings - Fork 1
PERFORMANCE_OPTIMIZATION_NOTES
Date: December 15, 2025
Status: Future Enhancements
Priority: P2 (Optional)
Version: v1.3.0
Kategorie: 🔒 Security
This document tracks potential performance optimizations for the vector encryption implementation. These are not critical for Phase 1-2 functionality but could improve performance for large-scale deployments.
Issue: Converting between std::vector<uint8_t> and std::string creates unnecessary copies for large HNSW indexes (multi-GB).
Current Implementation:
// serialize: vector<uint8_t> → string (copy)
std::string serialize(const std::vector<uint8_t>& value) {
return std::string(value.begin(), value.end());
}
// deserialize: string → vector<uint8_t> (copy)
std::vector<uint8_t> deserialize(const std::string& str) {
return std::vector<uint8_t>(str.begin(), str.end());
}Memory Impact:
- 3 GB HNSW index
- 2 copies: 6 GB peak memory usage
- Additional overhead during encryption/decryption
Optimization Options:
template<>
std::string EncryptedField<std::vector<uint8_t>>::serialize(std::vector<uint8_t>&& value) {
// Move data instead of copy
return std::string(
std::make_move_iterator(value.begin()),
std::make_move_iterator(value.end())
);
}Pros: Reduces copies
Cons: Requires API changes (rvalue references)
// Use string_view to avoid intermediate copies
std::string_view serializeView(const std::vector<uint8_t>& value) {
return std::string_view(
reinterpret_cast<const char*>(value.data()),
value.size()
);
}Pros: Zero-copy
Cons: Lifetime management complexity
// Encrypt directly from/to memory-mapped files
class MemoryMappedEncryption {
void encryptFile(const std::string& input, const std::string& output);
void decryptFile(const std::string& input, const std::string& output);
};Pros: No in-memory copies, handles huge files
Cons: Platform-specific, more complex
Recommendation: Option C for large indexes (>1 GB)
Estimated Impact:
- Memory reduction: 50% (6 GB → 3 GB peak)
- Performance: 10-20% faster for large indexes
Issue: Using istreambuf_iterator for multi-GB files is inefficient.
Current Implementation:
std::ifstream file(path, std::ios::binary);
std::vector<uint8_t> data(
(std::istreambuf_iterator<char>(file)),
std::istreambuf_iterator<char>()
);Problems:
- Character-by-character iteration
- No buffering optimization
- Slow for large files
Optimization:
std::vector<uint8_t> readFileChunked(const std::string& path) {
std::ifstream file(path, std::ios::binary);
// Get file size
file.seekg(0, std::ios::end);
size_t size = file.tellg();
file.seekg(0, std::ios::beg);
// Pre-allocate
std::vector<uint8_t> data(size);
// Read in chunks
const size_t chunk_size = 64 * 1024 * 1024; // 64 MB chunks
for (size_t i = 0; i < size; i += chunk_size) {
size_t read_size = std::min(chunk_size, size - i);
file.read(reinterpret_cast<char*>(data.data() + i), read_size);
}
return data;
}Pros: Much faster for large files
Cons: Slightly more complex
Estimated Impact:
- 3 GB file: 20 seconds → 5 seconds (4x faster)
#include <sys/mman.h>
class MMapFile {
void* map(const std::string& path, size_t& size);
void unmap(void* addr, size_t size);
};Pros: Fastest possible, OS-optimized
Cons: Platform-specific (Linux/Windows differ)
Recommendation: Option A for cross-platform, Option B for maximum performance
Issue: Large HNSW indexes encrypted/decrypted sequentially.
Current Implementation:
// Single-threaded encryption
EncryptedField<std::vector<uint8_t>> encField;
encField.encrypt(indexData, "hnsw_index"); // 3 GB takes 3 secondsOptimization: Chunk-Based Parallel Encryption
class ParallelEncryption {
std::vector<EncryptedChunk> encryptParallel(
const std::vector<uint8_t>& data,
const std::string& key_id,
size_t num_threads = 8
) {
const size_t chunk_size = 256 * 1024 * 1024; // 256 MB chunks
std::vector<EncryptedChunk> chunks;
#pragma omp parallel for
for (size_t i = 0; i < data.size(); i += chunk_size) {
size_t len = std::min(chunk_size, data.size() - i);
std::vector<uint8_t> chunk(data.begin() + i, data.begin() + i + len);
EncryptedField<std::vector<uint8_t>> encField;
encField.encrypt(chunk, key_id);
#pragma omp critical
chunks.push_back({i, encField});
}
return chunks;
}
};Estimated Impact:
- 3 GB encryption: 3 seconds → 0.5 seconds (8 cores)
- Near-linear scaling with core count
Challenges:
- Need to store chunk metadata
- Reconstruction on decryption
- Slightly more complex format
Issue: HNSW indexes have some redundancy that could be compressed.
Optimization:
class CompressedEncryption {
Status saveCompressedEncrypted(const std::string& directory) {
// 1. Save HNSW index
appr->saveIndex(tempPath);
// 2. Load into memory
auto data = readFile(tempPath);
// 3. Compress (e.g., zstd, lz4)
auto compressed = zstd::compress(data, level=3);
// 4. Encrypt compressed data
EncryptedField<std::vector<uint8_t>> encField;
encField.encrypt(compressed, "hnsw_index");
// 5. Save
writeFile(encryptedPath, encField.toBase64());
}
};Estimated Impact:
- Compression ratio: 0.7-0.9 (depends on HNSW structure)
- Storage savings: 10-30%
- CPU overhead: +10-20% (compression time)
Trade-off: CPU time for storage space
Issue: Vectors decrypted one-by-one during rebuildFromStorage().
Current Implementation:
for (auto& entity : entities) {
auto enc = EncryptedField<std::vector<float>>::fromBase64(entity.encryptedField);
auto vector = enc.decrypt(); // Sequential
cache[pk] = vector;
}Optimization: Parallel Batch Decryption
// Collect all encrypted fields
std::vector<EncryptedField<std::vector<float>>> encrypted_batch;
for (auto& entity : entities) {
encrypted_batch.push_back(
EncryptedField<std::vector<float>>::fromBase64(entity.encryptedField)
);
}
// Parallel decryption
std::vector<std::vector<float>> decrypted_batch(encrypted_batch.size());
#pragma omp parallel for
for (size_t i = 0; i < encrypted_batch.size(); ++i) {
decrypted_batch[i] = encrypted_batch[i].decrypt();
}
// Cache results
for (size_t i = 0; i < entities.size(); ++i) {
cache[entities[i].pk] = decrypted_batch[i];
}Estimated Impact:
- 1M vectors: 16 minutes → 2 minutes (8 cores, 8x speedup)
| Optimization | Phase | Priority | Effort | Impact |
|---|---|---|---|---|
| Chunked file reading | 2 | P1 | Low | High |
| Memory-mapped files | 2 | P2 | Medium | High |
| Parallel batch decrypt | 1 | P2 | Medium | High |
| Move semantics | 2 | P2 | Low | Medium |
| Compression | 2 | P3 | Medium | Medium |
| Parallel encryption | 2 | P3 | High | Medium |
- Implement chunked file reading (easy win)
- Add batch decryption for index rebuild
- Memory-mapped I/O for HNSW indexes
- Compression before encryption (optional)
- Parallel chunk-based encryption
- Hardware acceleration (AES-NI already used by OpenSSL)
Before optimizations:
- Measure baseline: 1M vectors, 3 GB HNSW index
- Profile bottlenecks: CPU, memory, I/O
After each optimization:
- Re-measure performance
- Verify correctness
- Document improvement
- EncryptedField implementation:
src/security/encrypted_field.cpp - HNSW save/load:
src/index/vector_index.cpp - Performance analysis:
PHASE2_IMPLEMENTATION_REPORT.md
Status: Documentation complete
Implementation: Future work
Priority: P2-P3 (optional performance enhancements)
- Architecture-ACCESS-MODEL-IMPLEMENTATION-SUMMARY
- Architecture-ADR-003-pg-dump-sql-parser
- Architecture-BASEENTITY-PRINCIPLE
- Architecture-CACHE-STORAGE-INTEGRATION
- Architecture-CMAKE-ARCHITECTURE
- Architecture-CMAKE-FLAGS-REFERENCE
- Architecture-CMAKE-MODULAR-ARCHITECTURE
- Architecture-CONCERNS-ARCHITECTURE-DIAGRAM
- Architecture-CONCERNS-IMPLEMENTATION-SUMMARY
- Architecture-CONTENT-MODEL
- Architecture-COPILOT-THEMISDB-GRAPH-RAG-BACKEND-ARCHITECTURE
- Architecture-CRYPTO-AND-KEYS
- Architecture-FEATURE-FLAGS-REFERENCE
- Architecture-GPU-ARCHITECTURE-REVIEW-TEMPLATE
- Architecture-HTTP-SHUTDOWN-HARDENING
- Architecture-MIGRATION-GUIDE-CONCERNS
- Architecture-MIGRATION-GUIDE-v13-v14
- Architecture-MODULARIZATION-GUIDE
- Architecture-MODULAR-ARCHITECTURE-ROADMAP
- Architecture-MODULE-ARCHITECTURE-INDEX
- Architecture-P1D01-ISSMPLUGIN-DESIGN-REVIEW
- Architecture-P1-D01-ISSMPLUGIN-DESIGN-REVIEW
- Architecture-P1-D08-MAMBA-GOVERNANCE-CONTRACT
- Architecture-P1-P2-IMPLEMENTATION-COMPLETION-INDEX
- Architecture-PHASE0-COMPLETION-ASSESSMENT
- Architecture-PHASE3-QUERYENGINE-DI-ARCHITECTURE
- Architecture-PHASE4-INDEX-MANAGER-DI
- Architecture-POSTGRESQL-WIRE-PROTOCOL
- Architecture-QUERYENGINE-IMPLEMENTATION-GUIDE
- Architecture-QUERY-SCHEDULING
- Architecture-RAFT-CONSENSUS-DESIGN
- Architecture-README
- Architecture-README-SSM-HYBRID-IMPLEMENTATION
- Architecture-REFACTORING-SUMMARY
- Architecture-RESOURCE-POOLING
- Architecture-SOURCE-DIRECTORY-GUIDE
- Architecture-THEMIS-CORE-GUIDE
- Architecture-UNIFIED-ACCESS-MODEL
- Architecture-WAL-GRPC-MTLS-CONFIGURATION
- Architecture-WIRE-PROTOCOL-RETRY
- Architecture-boltzmann-observability-draft
- Architecture-experimental-logarithmic-vector-storage
- Architecture-llm-wiki-mvp-adr
- Architecture-rewrite-engine-architecture
- Architecture-rope-api-architecture
- Architecture-ssm-gguf-mamba-status
- Architecture-ssm-hybrid-analysis
- Architecture-ssm-hybrid-rollout-plan
- Architecture-ssm-plugin-interface-design-review
- Architecture-transaction-coordinators
- Architecture-wiki-secondary-index
- Architecture-wire-protocol
- Governance-DISABLED-STUB-POLICY
- Governance-DOCS-PR-POLICY
- Governance-GA-PROMOTION-SIGN-OFF
- Governance-GITHUB-MILESTONES-SETUP
- Governance-MATURITY-CLAIM-VERIFICATION-CHECKLIST
- Governance-MATURITY-EVIDENCE-REGISTRY
- Governance-MERGE-GATE-BOT-CONFIG
- Governance-MERGE-GATE-STATUS-LIVE
- Governance-PHASE3-ENFORCEMENT-RUNBOOK
- Governance-PHASE-1-CLOSURE-REPORT
- Governance-PHASE-CLOSURE-POLICY
- Governance-PHASE-DEPENDENCY-GRAPH
- Governance-PLUGIN-SUBMODULE-ROLLBACK
- Governance-PRODUCTION-READY-2026-DELIVERY-PLAN
- Governance-PR-VERSION-TARGETING
- Governance-PR-VERSION-TARGETING-BACKFILL
- Governance-QUERY-MODULE-STATUS
- Governance-README
- Governance-RELEASE-PROMOTION-GATE-POLICY
- Governance-RELEASE-VALIDATION-CHECKLIST
- Governance-SECURITY-MODULE-5671-EVIDENCE-SUMMARY
- Governance-SHARDING-P6-RESIDUAL-RISK-ACCEPTANCE
- Governance-SOURCECODE-COMPLIANCE-GOVERNANCE
- Governance-UPDATES-DEVELOPMENT-STATUS-SIGN-OFF
- Governance-WAVE-C-IMPLEMENTATION-COMPLETE
- Module-acceleration-Roadmap
- Module-access-model-Roadmap
- Module-ai-Roadmap
- Module-analytics-Roadmap
- Module-api-Roadmap
- Module-aql-Roadmap
- Module-auth-Roadmap
- Module-base-Roadmap
- Module-cache-Roadmap
- Module-cdc-Roadmap
- Module-chaos-Roadmap
- Module-chimera-Roadmap
- Module-config-Roadmap
- Module-content-Roadmap
- Module-core-Roadmap
- Module-distributed-knowledge-Roadmap
- Module-distributed-tensor-Roadmap
- Module-document-Roadmap
- Module-ethics-ai-Roadmap
- Module-evaluation-Roadmap
- Module-execution-Roadmap
- Module-exporters-Roadmap
- Module-failover-Roadmap
- Module-geo-Roadmap
- Module-governance-Roadmap
- Module-gpu-Roadmap
- Module-graph-Roadmap
- Module-image-analysis-Roadmap
- Module-importers-Roadmap
- Module-index-Roadmap
- Module-ingestion-Roadmap
- Module-llama-cpp-Roadmap
- Module-llm-Roadmap
- Module-llm-streaming-Roadmap
- Module-llm-wiki-Roadmap
- Module-maintenance-Roadmap
- Module-metadata-Roadmap
- Module-network-Roadmap
- Module-observability-Roadmap
- Module-onnx-clip-Roadmap
- Module-performance-Roadmap
- Module-plugins-Roadmap
- Module-process-Roadmap
- Module-projects-Roadmap
- Module-prompt-engineering-Roadmap
- Module-query-Roadmap
- Module-rag-Roadmap
- Module-replication-Roadmap
- Module-retrieval-Roadmap
- Module-rpc-grpc-Roadmap
- Module-scheduler-Roadmap
- Module-scraper-Roadmap
- Module-search-Roadmap
- Module-security-Roadmap
- Module-server-Roadmap
- Module-sharding-Roadmap
- Module-stable-diffusion-Roadmap
- Module-storage-Roadmap
- Module-temporal-Roadmap
- Module-tensor-Roadmap
- Module-themis-Roadmap
- Module-timeseries-Roadmap
- Module-toolbox-Roadmap
- Module-training-Roadmap
- Module-transaction-Roadmap
- Module-updates-Roadmap
- Module-user-storage-encrypted-Roadmap
- Module-utils-Roadmap
- Module-vector-search-Roadmap
- Module-voice-Roadmap
- Module-whisper-Roadmap