ci: align pre-commit hooks and GitHub templates - #133
Conversation
Adopt the shared pre-commit baseline: two-line SPDX header, conventional commit message validation (commit-msg stage), and the centralized add-license / add-spdx-license hooks from developer_tools v0.2.0. Run pre-commit CI only on files modified by the PR, and roll out the standard issue templates and the simplified single PR template. TRI-1100
Legal's Copyright / License Header Guidance specifies the SPDX form without a comma after the year. TRI-1100
Human-readable type labels with enforced descriptions and colors. TRI-1100
The add-license hook now fails when the LICENSE copyright year is stale. TRI-1100
Workflow files are license-processed again (only templates excluded); refresh the stale copyright year this repo's pre-commit workflow carried. TRI-1100
Grant issues:write to the labeling job (review feedback). TRI-1100
Greptile SummaryThis PR aligns the repository's CI tooling with the org-wide setup in
Confidence Score: 5/5Safe to merge; all changes are CI tooling with no impact on production code or existing workflows. All three files touch only CI configuration. The dual-trigger pattern in conventional-pr.yml is correctly gated to prevent double-runs and privilege escalation from fork PRs. The pre-commit pipeline change (null-delimited git diff | xargs) is sound for the ubuntu runner. The only finding is a minor inconsistency in action version pinning style. No files require special attention beyond confirming that v1.4.3 exists in triton-inference-server/.github before merging. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
PR[Pull Request event] --> E{Event type?}
E -->|pull_request same-repo| C1{head.repo == repository?}
E -->|pull_request_target fork| C2{head.repo != repository?}
C1 -->|Yes| J1[conventional-pr job limited token]
C1 -->|No| SKIP1[Job skipped]
C2 -->|Yes| J2[conventional-pr job writable token]
C2 -->|No| SKIP2[Job skipped]
J1 --> RW[Calls reusable workflow at v1.4.3]
J2 --> RW
RW --> VA[Validate PR title vs Conventional Commits]
VA --> LA[Derive and apply type label]
LA --> OK[Pass]
subgraph pre-commit CI
PC1[checkout fetch-depth 2] --> PC2[setup-python]
PC2 --> PC3[restore hook env cache]
PC3 --> PC4[git diff HEAD^1 HEAD null-delimited]
PC4 --> PC5{Files modified?}
PC5 -->|Yes| PC6[pre-commit run on changed files only]
PC5 -->|No| PC7[skip via no-run-if-empty]
end
Reviews (2): Last reviewed commit: "ci: harden CI workflows and configs per ..." | Re-trigger Greptile |
- conventional-pr stub: dual pull_request/pull_request_target triggers so fork PRs from external contributors get labeled too (the reusable workflow never checks out PR code); explicit contents:read; pinned v1.4.3. - pre-commit workflow: robust modified-files runner (null-delimited paths, deletion-only PRs handled, deleted paths filtered, no undocumented -r flag, cache keyed on config hash). - flake8 args quoted correctly (the flow-scalar form split at commas and silently reduced the select list). - hooks pinned to .github v1.4.3. TRI-1100
|
Closing: the team is moving away from centralized org-level configuration in favor of per-repository self-contained setups (see triton-inference-server/server#8897 for the first decentralized implementation). Branch retained for reference. TRI-1100 |
What does the PR do?
Aligns this repository with the org-wide setup consolidated in triton-inference-server/.github:
.pre-commit-config.yaml: shared baseline hooks, conventional-commit message validation (commit-msg stage), and the centralizedadd-licensehook from the org.githubrepository (rev: v1.4.3— excludes.github/templates, never rewrites LICENSE files).conventional-prworkflow (@v1.4.3): validates the PR title against Conventional Commits (hard gate — it becomes the squash-merge commit), derives one human-readable label per distinct type found in the title and all conforming commit subjects (e.g.ci:→CI/CD,feat:→feature,fix:→fix), enforces org-wide label colors/descriptions, detects cherry-picks, and fails if no type is derivable and no type label is assigned.Repo-specific: keeps the
deploy/templatescheck-yaml exclude.Depends on triton-inference-server/.github#5 (pinned tags current:
v1.4.3— already exist, CI is green).Pros / Cons
Pros
.githubrepo) for hooks, templates, issue routing, and the PR-title workflow — one change propagates everywhere.Cons / risks
.githubrepository (tags are write-once; changes ship as a new tag + rev bump)..githubrepository to remain public.Related Issues / PRs
Related PRs:
Test plan
pre-commit validate-configpasses;pre-commit run --files <PR diff>passes locally with the centralized hooks pinned to the .github branch SHA.v1.4.3exists: the conventional-pr check validates this PR's own title and applies thecilabel.Caveats
Checklist
<commit_type>: <Title>(conventional commit)