ci: align pre-commit hooks and GitHub templates - #24
Conversation
Adopt the shared pre-commit baseline: two-line SPDX header, conventional commit message validation (commit-msg stage), and the centralized add-license / add-spdx-license hooks from developer_tools v0.2.0. Run pre-commit CI only on files modified by the PR, and roll out the standard issue templates and the simplified single PR template. TRI-1100
Legal's Copyright / License Header Guidance specifies the SPDX form without a comma after the year. TRI-1100
Human-readable type labels with enforced descriptions and colors. TRI-1100
Deliberate maintenance bump to include the year of the current modifications; required by the add-license hook's new staleness check (hooks themselves never modify LICENSE files). TRI-1100
Workflow files are license-processed again (only templates excluded); refresh the stale copyright year this repo's pre-commit workflow carried. TRI-1100
Grant issues:write to the labeling job (review feedback). TRI-1100
Greptile SummaryThis PR aligns the
Confidence Score: 5/5Safe to merge — all changes are CI/configuration files with no impact on the cache plugin's runtime behavior. The PR adds two thin workflow stubs and updates pre-commit config. The pull_request_target guard is correctly constructed to avoid running elevated-permission jobs on same-repo PRs. The null-delimited xargs pipeline, cache step, and add-license hook are all straightforward and well-commented. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
PR[Pull Request Event] --> Q1{Same-repo or fork?}
Q1 -->|Same-repo| PE[pull_request event]
Q1 -->|Fork| PTE[pull_request_target event]
PE --> IF1{if: head.repo == github.repository}
PTE --> IF2{if: head.repo != github.repository}
IF1 -->|true| CW[conventional-pr reusable workflow at v1.4.3]
IF2 -->|true| CW
IF1 -->|false| SKIP1[job skipped]
IF2 -->|false| SKIP2[job skipped]
CW --> LABEL[Apply type label]
CW --> VALIDATE[Validate PR title]
PR --> PC[pre-commit workflow]
PC --> DIFF[git diff -z HEAD^1 HEAD]
DIFF --> XARGS[xargs -0 pre-commit run --files]
XARGS --> HOOKS[Run hooks on changed files only]
Reviews (2): Last reviewed commit: "ci: harden CI workflows and configs per ..." | Re-trigger Greptile |
- conventional-pr stub: dual pull_request/pull_request_target triggers so fork PRs from external contributors get labeled too (the reusable workflow never checks out PR code); explicit contents:read; pinned v1.4.3. - pre-commit workflow: robust modified-files runner (null-delimited paths, deletion-only PRs handled, deleted paths filtered, no undocumented -r flag, cache keyed on config hash). - flake8 args quoted correctly (the flow-scalar form split at commas and silently reduced the select list). - hooks pinned to .github v1.4.3. TRI-1100
|
Closing: the team is moving away from centralized org-level configuration in favor of per-repository self-contained setups (see triton-inference-server/server#8897 for the first decentralized implementation). Branch retained for reference. TRI-1100 |
What does the PR do?
Aligns this repository with the org-wide setup consolidated in triton-inference-server/.github:
.pre-commit-config.yaml: shared baseline hooks, conventional-commit message validation (commit-msg stage), and the centralizedadd-licensehook from the org.githubrepository (rev: v1.4.3— excludes.github/templates, never rewrites LICENSE files).conventional-prworkflow (@v1.4.3): validates the PR title against Conventional Commits (hard gate — it becomes the squash-merge commit), derives one human-readable label per distinct type found in the title and all conforming commit subjects (e.g.ci:→CI/CD,feat:→feature,fix:→fix), enforces org-wide label colors/descriptions, detects cherry-picks, and fails if no type is derivable and no type label is assigned.Depends on triton-inference-server/.github#5 (pinned tags current:
v1.4.3— already exist, CI is green).Pros / Cons
Pros
.githubrepo) for hooks, templates, issue routing, and the PR-title workflow — one change propagates everywhere.Cons / risks
.githubrepository (tags are write-once; changes ship as a new tag + rev bump)..githubrepository to remain public.Related Issues / PRs
Related PRs:
Test plan
pre-commit validate-configpasses;pre-commit run --files <PR diff>passes locally with the centralized hooks pinned to the .github branch SHA.v1.4.3exists: the conventional-pr check validates this PR's own title and applies thecilabel.Caveats
Checklist
<commit_type>: <Title>(conventional commit)