Skip to content

ci: align pre-commit hooks and GitHub templates - #467

Closed
mc-nv wants to merge 17 commits into
mainfrom
mchornyi/TRI-1100/github-align-hooks-and-templates
Closed

ci: align pre-commit hooks and GitHub templates#467
mc-nv wants to merge 17 commits into
mainfrom
mchornyi/TRI-1100/github-align-hooks-and-templates

Conversation

@mc-nv

@mc-nv mc-nv commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Aligns this repository with the org-wide setup consolidated in triton-inference-server/.github:

  • .pre-commit-config.yaml: shared baseline hooks, conventional-commit message validation (commit-msg stage), and the centralized add-license hook from the org .github repository (rev: v1.4.3 — excludes .github/ templates, never rewrites LICENSE files).
  • Pre-commit CI runs only on files modified by the PR.
  • Caller stub for the org-wide reusable conventional-pr workflow (@v1.4.3): validates the PR title against Conventional Commits (hard gate — it becomes the squash-merge commit), derives one human-readable label per distinct type found in the title and all conforming commit subjects (e.g. ci:CI/CD, feat:feature, fix:fix), enforces org-wide label colors/descriptions, detects cherry-picks, and fails if no type is derivable and no type label is assigned.
  • No per-repo templates: PR templates and issue routing are inherited from the org-wide defaults in triton-inference-server/.github (issues route to the server repository).

Repo-specific: keeps the newer black 24.4.0 / clang-format v18.1.3 revs, the mypy hook, and the codespell shakespeare exclude.

Depends on triton-inference-server/.github#5 (pinned tags current: v1.4.3 — already exist, CI is green).

Pros / Cons

Pros

  • Single home (org .github repo) for hooks, templates, issue routing, and the PR-title workflow — one change propagates everywhere.
  • Repos carry only a config file and two small workflow stubs; no template copies to drift.
  • Commit/PR title format enforced both locally (commit-msg hook) and in CI (reusable workflow), with automatic type labels.
  • License hooks never modify LICENSE files.

Cons / risks

  • Version-pinned dependency on the org .github repository (tags are write-once; changes ship as a new tag + rev bump).
  • Template inheritance requires the org .github repository to remain public.

Related Issues / PRs

  • Resolves: TRI-1100

Related PRs:

Test plan

  • pre-commit validate-config passes; pre-commit run --files <PR diff> passes locally with the centralized hooks pinned to the .github branch SHA.
  • After .github#5 merges and v1.4.3 exists: the conventional-pr check validates this PR's own title and applies the ci label.
  • No LICENSE file content is changed by this PR.

Caveats

  • None beyond the merge-order note above.

Checklist

  • PR title follows <commit_type>: <Title> (conventional commit)
  • I ran pre-commit locally on all files changed by this PR and it passes
  • Copyright header is correct on all changed files
  • External contributors: I have read the Contribution guidelines and signed the Contributor License Agreement

Adopt the shared pre-commit baseline: two-line SPDX header, conventional
commit message validation (commit-msg stage), and the centralized
add-license / add-spdx-license hooks from developer_tools v0.2.0.
Run pre-commit CI only on files modified by the PR, and roll out the
standard issue templates and the simplified single PR template.

TRI-1100
@mc-nv mc-nv self-assigned this Jul 18, 2026
This was referenced Jul 18, 2026
Legal's Copyright / License Header Guidance specifies the SPDX form
without a comma after the year.

TRI-1100
@mc-nv
mc-nv marked this pull request as ready for review July 18, 2026 02:05
@mc-nv
mc-nv requested review from mudit-eng and nv-rinig July 18, 2026 02:20
@github-actions github-actions Bot added the CI/CD Continuous integration and workflow changes (ci: PRs) label Jul 20, 2026
@github-actions github-actions Bot added the chore Maintenance work, no production code change (chore: PRs) label Jul 20, 2026
The add-license hook now fails when the LICENSE copyright year is
stale.

TRI-1100
Workflow files are license-processed again (only templates excluded);
refresh the stale copyright year this repo's pre-commit workflow
carried.

TRI-1100
Grant issues:write to the labeling job (review feedback).

TRI-1100
@Vinya567

Copy link
Copy Markdown

@greptileai

@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown

Greptile Summary

This PR aligns the repo with the org-wide CI setup by introducing a thin conventional-pr workflow caller, modernizing the pre-commit workflow to use a direct pip install with an explicit cache step, and updating .pre-commit-config.yaml to add the conventional-pre-commit commit-msg hook and replace the local add-license script with the centralized org hook.

  • conventional-pr.yml (new): delegates PR-title validation and type-label management to the org-wide reusable workflow at v1.4.3, correctly routing same-repo PRs through pull_request and fork PRs through pull_request_target.
  • pre-commit.yml: swaps pre-commit/action for a direct pip install + null-delimited xargs invocation, adds an explicit ~/.cache/pre-commit cache step, and scopes permissions to contents: read.
  • .pre-commit-config.yaml: adds default_install_hook_types: [pre-commit, commit-msg], wires in conventional-pre-commit for commit-msg validation, and fixes the extraneous spaces in the flake8 --extend-ignore= argument.

Confidence Score: 5/5

Safe to merge; changes are scoped entirely to CI configuration files and the pre-commit hook config — no application code is touched.

All three changed files are CI/tooling configuration. The workflow logic is straightforward, the pull_request_target usage is intentionally guarded and documented inline, and the hook version pins are consistent across both files that reference the org .github repo.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/conventional-pr.yml New thin-caller workflow delegating PR title validation and labeling to the org-wide reusable workflow at v1.4.3; correctly partitions same-repo vs fork PRs across pull_request / pull_request_target events.
.github/workflows/pre-commit.yml Replaces the pre-commit/action step with a direct pip install + manual invocation; adds an explicit pre-commit cache step; upgrades copyright year and scopes permissions to contents: read.
.pre-commit-config.yaml Adds default_install_hook_types, conventional-pre-commit hook for commit-msg stage, replaces local add-license script with the centralized org hook at v1.4.3, reformats YAML indentation, and fixes the flake8 --extend-ignore= spacing.

Reviews (2): Last reviewed commit: "ci: harden CI workflows and configs per ..." | Re-trigger Greptile

Comment thread .github/workflows/conventional-pr.yml Outdated
permissions:
pull-requests: write
issues: write
uses: triton-inference-server/.github/.github/workflows/conventional-pr.yml@v1.4.2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Version mismatch with PR description

The PR description says throughout that this PR pins to v1.4.1 ("pinned tags current: v1.4.1 — already exist, CI is green", "After .github#5 merges and v1.4.1 exists"), but the actual code here references @v1.4.2. The same discrepancy appears in .pre-commit-config.yaml at line 94 (rev: v1.4.2). If v1.4.2 does not yet exist in the triton-inference-server/.github repository, the conventional-pr CI job will fail on every PR from the moment this is merged.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - documentation drift: the descriptions have been refreshed to the current pinned tag v1.4.3 (they lagged behind the tag revisions; the tag exists and CI is green fleet-wide).

- conventional-pr stub: dual pull_request/pull_request_target triggers
  so fork PRs from external contributors get labeled too (the reusable
  workflow never checks out PR code); explicit contents:read; pinned
  v1.4.3.
- pre-commit workflow: robust modified-files runner (null-delimited
  paths, deletion-only PRs handled, deleted paths filtered, no
  undocumented -r flag, cache keyed on config hash).
- flake8 args quoted correctly (the flow-scalar form split at commas
  and silently reduced the select list).
- hooks pinned to .github v1.4.3.

TRI-1100

@Vinya567 Vinya567 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mc-nv

mc-nv commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing: the team is moving away from centralized org-level configuration in favor of per-repository self-contained setups (see triton-inference-server/server#8897 for the first decentralized implementation). Branch retained for reference. TRI-1100

@mc-nv mc-nv closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance work, no production code change (chore: PRs) CI/CD Continuous integration and workflow changes (ci: PRs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants