Skip to content

ci: align pre-commit hooks and GitHub templates - #127

Closed
mc-nv wants to merge 17 commits into
mainfrom
mchornyi/TRI-1100/github-align-hooks-and-templates
Closed

ci: align pre-commit hooks and GitHub templates#127
mc-nv wants to merge 17 commits into
mainfrom
mchornyi/TRI-1100/github-align-hooks-and-templates

Conversation

@mc-nv

@mc-nv mc-nv commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Aligns this repository with the org-wide setup consolidated in triton-inference-server/.github:

  • .pre-commit-config.yaml: shared baseline hooks, conventional-commit message validation (commit-msg stage), and the centralized add-license hook from the org .github repository (rev: v1.4.3 — excludes .github/ templates, never rewrites LICENSE files).
  • Pre-commit CI runs only on files modified by the PR.
  • Caller stub for the org-wide reusable conventional-pr workflow (@v1.4.3): validates the PR title against Conventional Commits (hard gate — it becomes the squash-merge commit), derives one human-readable label per distinct type found in the title and all conforming commit subjects (e.g. ci:CI/CD, feat:feature, fix:fix), enforces org-wide label colors/descriptions, detects cherry-picks, and fails if no type is derivable and no type label is assigned.
  • No per-repo templates: PR templates and issue routing are inherited from the org-wide defaults in triton-inference-server/.github (issues route to the server repository).

Depends on triton-inference-server/.github#5 (pinned tags current: v1.4.3 — already exist, CI is green).

Pros / Cons

Pros

  • Single home (org .github repo) for hooks, templates, issue routing, and the PR-title workflow — one change propagates everywhere.
  • Repos carry only a config file and two small workflow stubs; no template copies to drift.
  • Commit/PR title format enforced both locally (commit-msg hook) and in CI (reusable workflow), with automatic type labels.
  • License hooks never modify LICENSE files.

Cons / risks

  • Version-pinned dependency on the org .github repository (tags are write-once; changes ship as a new tag + rev bump).
  • Template inheritance requires the org .github repository to remain public.

Related Issues / PRs

  • Resolves: TRI-1100

Related PRs:

Test plan

  • pre-commit validate-config passes; pre-commit run --files <PR diff> passes locally with the centralized hooks pinned to the .github branch SHA.
  • After .github#5 merges and v1.4.3 exists: the conventional-pr check validates this PR's own title and applies the ci label.
  • No LICENSE file content is changed by this PR.

Caveats

  • None beyond the merge-order note above.

Checklist

  • PR title follows <commit_type>: <Title> (conventional commit)
  • I ran pre-commit locally on all files changed by this PR and it passes
  • Copyright header is correct on all changed files
  • External contributors: I have read the Contribution guidelines and signed the Contributor License Agreement

Adopt the shared pre-commit baseline: two-line SPDX header, conventional
commit message validation (commit-msg stage), and the centralized
add-license / add-spdx-license hooks from developer_tools v0.2.0.
Run pre-commit CI only on files modified by the PR, and roll out the
standard issue templates and the simplified single PR template.

TRI-1100
@mc-nv mc-nv self-assigned this Jul 18, 2026
This was referenced Jul 18, 2026
Legal's Copyright / License Header Guidance specifies the SPDX form
without a comma after the year.

TRI-1100
@mc-nv
mc-nv marked this pull request as ready for review July 18, 2026 02:04
Human-readable type labels with enforced descriptions and colors.

TRI-1100
@github-actions github-actions Bot added CI/CD Continuous integration and workflow changes (ci: PRs) and removed ci labels Jul 20, 2026
@github-actions github-actions Bot added the chore Maintenance work, no production code change (chore: PRs) label Jul 20, 2026
mc-nv added 2 commits July 21, 2026 08:14
The add-license hook now fails when the LICENSE copyright year is
stale.

TRI-1100
Workflow files are license-processed again (only templates excluded);
refresh the stale copyright year this repo's pre-commit workflow
carried.

TRI-1100
@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown

Greptile Summary

This PR aligns the repository's CI and local tooling with the org-wide baseline by introducing a thin conventional-pr caller workflow and updating the existing pre-commit workflow and .pre-commit-config.yaml.

  • conventional-pr.yml (new): Delegates PR-title validation and label management to the org reusable workflow at v1.4.3, with correct pull_request / pull_request_target event routing for same-repo vs fork PRs and the three necessary permissions (pull-requests: write, issues: write, contents: read).
  • pre-commit.yml (updated): Replaces the pre-commit/action step with an explicit pip install pre-commit + git diff -z | xargs -0 pre-commit run --files pipeline; adds a ~/.cache/pre-commit cache step and a contents: read permission; null-delimiter handling and --diff-filter=d correctly exclude deleted files.
  • .pre-commit-config.yaml (updated): Adds default_install_hook_types: [pre-commit, commit-msg], a conventional-pre-commit commit-msg hook, and migrates add-license from triton-inference-server/developer_tools@v0.1.0 to triton-inference-server/.github@v1.4.3; also fixes the erroneous space in the flake8 --extend-ignore argument.

Confidence Score: 5/5

Safe to merge — changes are limited to CI workflows and the pre-commit config; no production code is touched.

All three files make narrow, well-scoped changes to CI infrastructure. The fork-PR event routing in conventional-pr.yml follows the standard GitHub pattern and is correctly guarded by the if condition. The pre-commit pipeline refactor uses null-delimited output and --diff-filter=d, which are the right tools for the job. No functional regressions are introduced.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/conventional-pr.yml New caller stub for the org-wide reusable conventional-pr workflow; correctly gates same-repo vs fork PRs and carries the three required permissions.
.github/workflows/pre-commit.yml Replaces pre-commit/action with a manual pip-install + `git diff
.pre-commit-config.yaml Adds default_install_hook_types, conventional-commit message hook, fixes the erroneous space in the flake8 --extend-ignore arg, and migrates add-license to the org .github repo at v1.4.3.

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub
    participant PC as pre-commit (CI)
    participant CP as conventional-pr (CI)
    participant RW as Reusable Workflow<br/>(.github@v1.4.3)

    Dev->>Dev: git commit (conventional-pre-commit hook validates msg)
    Dev->>GH: Push / open PR

    GH->>PC: pull_request event
    PC->>PC: checkout (fetch-depth: 2)
    PC->>PC: restore ~/.cache/pre-commit
    PC->>PC: "git diff HEAD^1 HEAD (--diff-filter=d, -z)"
    PC->>PC: xargs -0 pre-commit run --files
    PC-->>GH: pass / fail

    GH->>CP: pull_request (same-repo) OR pull_request_target (fork)
    Note over CP: if condition guards event routing
    CP->>RW: "uses: conventional-pr.yml@v1.4.3"
    RW->>GH: Validate PR title (Conventional Commits)
    RW->>GH: Derive and apply type label
    RW-->>CP: pass / fail
    CP-->>GH: status check result
Loading

Reviews (5): Last reviewed commit: "ci: harden CI workflows and configs per ..." | Re-trigger Greptile

Comment thread .github/workflows/conventional-pr.yml Outdated
Comment thread .github/workflows/conventional-pr.yml
Comment thread .github/workflows/conventional-pr.yml Outdated
Grant issues:write to the labeling job (review feedback).

TRI-1100
@mc-nv

mc-nv commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review — the issues: write permission is now granted on both the reusable workflow job and the caller stubs (v1.4.2, rolled out fleet-wide), addressing the P1 findings in code rather than by argument. Descriptions were refreshed for P2 earlier.

Vinya567
Vinya567 previously approved these changes Jul 22, 2026
@mc-nv
mc-nv requested a review from pskiran1 July 22, 2026 15:11
@Vinya567

Copy link
Copy Markdown

@greptileai

- conventional-pr stub: dual pull_request/pull_request_target triggers
  so fork PRs from external contributors get labeled too (the reusable
  workflow never checks out PR code); explicit contents:read; pinned
  v1.4.3.
- pre-commit workflow: robust modified-files runner (null-delimited
  paths, deletion-only PRs handled, deleted paths filtered, no
  undocumented -r flag, cache keyed on config hash).
- flake8 args quoted correctly (the flow-scalar form split at commas
  and silently reduced the select list).
- hooks pinned to .github v1.4.3.

TRI-1100
@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown

Want your agent to iterate on Greptile's feedback? Try greploops.

@mc-nv

mc-nv commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing: the team is moving away from centralized org-level configuration in favor of per-repository self-contained setups (see triton-inference-server/server#8897 for the first decentralized implementation). Branch retained for reference. TRI-1100

@mc-nv mc-nv closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance work, no production code change (chore: PRs) CI/CD Continuous integration and workflow changes (ci: PRs)

Development

Successfully merging this pull request may close these issues.

2 participants