ci: align pre-commit hooks and GitHub templates - #124
Conversation
Adopt the shared pre-commit baseline: two-line SPDX header, conventional commit message validation (commit-msg stage), and the centralized add-license / add-spdx-license hooks from developer_tools v0.2.0. Run pre-commit CI only on files modified by the PR, and roll out the standard issue templates and the simplified single PR template. TRI-1100
Legal's Copyright / License Header Guidance specifies the SPDX form without a comma after the year. TRI-1100
Human-readable type labels with enforced descriptions and colors. TRI-1100
The add-license hook now fails when the LICENSE copyright year is stale. TRI-1100
Workflow files are license-processed again (only templates excluded); refresh the stale copyright year this repo's pre-commit workflow carried. TRI-1100
Grant issues:write to the labeling job (review feedback). TRI-1100
Greptile SummaryThis PR aligns the repository with the org-wide CI setup in
Confidence Score: 5/5Safe to merge — all three files contain only CI/hook configuration with no functional code changes, and the pull_request_target usage is appropriately gated. The changes are purely CI and pre-commit configuration. The pull_request_target event in conventional-pr.yml is constrained by a repo-identity condition and grants only the permissions needed for label management; the reusable workflow is pinned to a write-once tag in the same org. The pre-commit.yml improvements (null-delimited xargs, --diff-filter=d, caching) are strictly better than the previous implementation. The flake8 arg fix in .pre-commit-config.yaml removes a stray space that would have silently misparsed the --extend-ignore flag. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant OrgWF as triton-inference-server/.github reusable workflows (v1.4.3)
participant Repo as Repo Labels / PR
Dev->>GH: Open / Edit PR
GH->>GH: conventional-pr.yml triggers (pull_request for same-repo, pull_request_target for forks)
GH->>OrgWF: "uses: conventional-pr.yml@v1.4.3 permissions: pull-requests:write, issues:write"
OrgWF->>Repo: Read PR title + commit subjects
OrgWF->>Repo: Validate Conventional Commits format
OrgWF->>Repo: Apply type label (ci/feat/fix/...)
Dev->>Dev: git commit
Dev->>Dev: commit-msg hook runs (conventional-pre-commit v4.4.0)
Dev->>Dev: pre-commit hooks run (isort, black, flake8, clang-format, codespell, pre-commit-hooks, add-license)
Note over GH: pre-commit.yml (PR CI)
GH->>GH: "git diff -z --diff-filter=d HEAD^1 HEAD"
GH->>GH: xargs -0 pre-commit run --files
GH->>OrgWF: add-license hook at v1.4.3
Reviews (2): Last reviewed commit: "ci: harden CI workflows and configs per ..." | Re-trigger Greptile |
- conventional-pr stub: dual pull_request/pull_request_target triggers so fork PRs from external contributors get labeled too (the reusable workflow never checks out PR code); explicit contents:read; pinned v1.4.3. - pre-commit workflow: robust modified-files runner (null-delimited paths, deletion-only PRs handled, deleted paths filtered, no undocumented -r flag, cache keyed on config hash). - flake8 args quoted correctly (the flow-scalar form split at commas and silently reduced the select list). - hooks pinned to .github v1.4.3. TRI-1100
|
Closing: the team is moving away from centralized org-level configuration in favor of per-repository self-contained setups (see triton-inference-server/server#8897 for the first decentralized implementation). Branch retained for reference. TRI-1100 |
What does the PR do?
Aligns this repository with the org-wide setup consolidated in triton-inference-server/.github:
.pre-commit-config.yaml: shared baseline hooks, conventional-commit message validation (commit-msg stage), and the centralizedadd-licensehook from the org.githubrepository (rev: v1.4.3— excludes.github/templates, never rewrites LICENSE files).conventional-prworkflow (@v1.4.3): validates the PR title against Conventional Commits (hard gate — it becomes the squash-merge commit), derives one human-readable label per distinct type found in the title and all conforming commit subjects (e.g.ci:→CI/CD,feat:→feature,fix:→fix), enforces org-wide label colors/descriptions, detects cherry-picks, and fails if no type is derivable and no type label is assigned.Depends on triton-inference-server/.github#5 (pinned tags current:
v1.4.3— already exist, CI is green).Pros / Cons
Pros
.githubrepo) for hooks, templates, issue routing, and the PR-title workflow — one change propagates everywhere.Cons / risks
.githubrepository (tags are write-once; changes ship as a new tag + rev bump)..githubrepository to remain public.Related Issues / PRs
Related PRs:
Test plan
pre-commit validate-configpasses;pre-commit run --files <PR diff>passes locally with the centralized hooks pinned to the .github branch SHA.v1.4.3exists: the conventional-pr check validates this PR's own title and applies thecilabel.Caveats
Checklist
<commit_type>: <Title>(conventional commit)