backend: write robot description to TrossenMCAP files#274
Open
abhichothani42 wants to merge 2 commits into
Open
backend: write robot description to TrossenMCAP files#274abhichothani42 wants to merge 2 commits into
abhichothani42 wants to merge 2 commits into
Conversation
This was referenced Jul 14, 2026
Collaborator
Author
This was referenced Jul 14, 2026
abhichothani42
marked this pull request as ready for review
July 14, 2026 06:13
There was a problem hiding this comment.
Pull request overview
This PR enhances the trossen_mcap backend so each recorded MCAP episode can optionally embed the exact robot model (URDF) it was recorded with, improving reproducibility and downstream tooling compatibility.
Changes:
- Add a
git_reffield to theRobotDescriptionprotobuf so the embedded URDF can be tied to a specific description version. - Introduce a fixed
/robot_descriptiontopic helper for a dedicated robot description channel. - Write a single
RobotDescriptionmessage duringTrossenMCAPBackend::open()(when enabled), track arobot_description_writtenstat, and ensure the channel is closed/reset during teardown.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/backends/trossen_mcap/trossen_mcap_backend.cpp | Adds URDF resolution + one-shot write on open; introduces robot description channel creation and teardown; registers the new schema blob. |
| include/trossen_sdk/io/backends/trossen_mcap/trossen_mcap_schemas.hpp | Adds robot_description_topic() returning /robot_description. |
| include/trossen_sdk/io/backends/trossen_mcap/trossen_mcap_backend.hpp | Adds stats + members and declares helpers for the robot description channel/message write. |
| include/trossen_sdk/io/backends/trossen_mcap/proto/RobotDescription.proto | Extends the proto with a git_ref field for provenance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abhichothani42
force-pushed
the
urdf-03-mcap-backend
branch
from
July 17, 2026 14:48
0497c7f to
d6268e2
Compare
abhichothani42
force-pushed
the
urdf-02-backend-config
branch
2 times, most recently
from
July 17, 2026 15:21
a7e19c7 to
a51dcee
Compare
abhichothani42
force-pushed
the
urdf-03-mcap-backend
branch
from
July 17, 2026 15:21
d6268e2 to
1ba2f6e
Compare
abhichothani42
force-pushed
the
urdf-02-backend-config
branch
from
July 17, 2026 16:33
a51dcee to
7f15201
Compare
abhichothani42
force-pushed
the
urdf-03-mcap-backend
branch
from
July 17, 2026 16:33
1ba2f6e to
830d5f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Writes the robot's URDF into every MCAP file. On
open(), wheninclude_robot_descriptionis set, the backend resolves the URDF throughRobotDescriptionCacheand logs a single message on a/robot_descriptionchannel, so each episode file carries the exact robot model it was recorded with.Changes
git_refto theRobotDescriptionproto so the file records which description version it embeds.robot_description_topic()(/robot_description) to the TrossenMCAP topic helpers.TrossenMCAPBackend::open(), plus arobot_description_writtenstat and clean channel teardown inclose_resources().Test Plan
make build)pre-commit run --all-files)Breaking Changes
None. With
include_robot_description=false(the default) the output files are unchanged.Related Issues
None.