Skip to content

backend: add end-effector pose write support to TrossenMCAP#268

Open
abhichothani42 wants to merge 1 commit into
eef-01-record-and-protofrom
eef-02-mcap-backend
Open

backend: add end-effector pose write support to TrossenMCAP#268
abhichothani42 wants to merge 1 commit into
eef-01-record-and-protofrom
eef-02-mcap-backend

Conversation

@abhichothani42

@abhichothani42 abhichothani42 commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Wires EndEffectorPoseRecord into the MCAP writer so that once the arm producer starts emitting these records (next PR), they are serialized and stored correctly. Follows the same pattern as Odometry2DRecord.

Changes

  • Add end_effector_pose_topic() helper to trossen_mcap_schemas.hpp — returns <stream_id>/end_effector/pose.
  • Add channel map, end_effector_pose_written stat counter, schema string member, and method declarations to TrossenMcapBackend.
  • Implement ensure_end_effector_pose_channel(), write_end_effector_pose_record(), dispatch in write() and write_batch(), schema registration, and cleanup in close_resources().

Test Plan

  • Builds cleanly (make build)
  • Tests pass (make test)
  • Lint passes (pre-commit run --all-files)
  • Tested on hardware (if applicable)

Breaking Changes

None.

Related Issues

Part of the end-effector pose recording feature stack.

abhichothani42 commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Wires EndEffectorPoseRecord into the MCAP writer: channel creation,
serialization, write dispatch, schema registration, and a stat counter.
Follows the same pattern as Odometry2DRecord.
@abhichothani42
abhichothani42 force-pushed the eef-01-record-and-proto branch from b70c835 to 61fcb75 Compare July 17, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants