Skip to content

arm: add EndEffectorPoseRecord and proto schema#267

Open
abhichothani42 wants to merge 2 commits into
vr-10-example-mobilefrom
eef-01-record-and-proto
Open

arm: add EndEffectorPoseRecord and proto schema#267
abhichothani42 wants to merge 2 commits into
vr-10-example-mobilefrom
eef-01-record-and-proto

Conversation

@abhichothani42

@abhichothani42 abhichothani42 commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Defines EndEffectorPoseRecord and its protobuf schema — the data type used to store end-effector pose in MCAP files. Nothing emits this record yet; this PR just establishes what the data looks like.

Changes

  • Add EndEffectorPoseRecord struct to record.hpp: x, y, z, rotation_x, rotation_y, rotation_z, and gripper_position fields.
  • Add EndEffectorPose.proto with one named scalar field per axis plus timestamp and sequence number.
  • Register EndEffectorPose.proto in CMakeLists.txt so it is compiled alongside the other SDK schemas.

Test Plan

  • Builds cleanly (make build)
  • Tests pass (make test)
  • Lint passes (pre-commit run --all-files)
  • Tested on hardware (if applicable)

Breaking Changes

None.

Related Issues

Part of the end-effector pose recording feature stack.

abhichothani42 commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread include/trossen_sdk/data/record.hpp Outdated
@abhichothani42
abhichothani42 changed the base branch from vr-10-example-mobile to graphite-base/267 July 10, 2026 14:33
@abhichothani42
abhichothani42 force-pushed the eef-01-record-and-proto branch from 3d212f9 to 517e781 Compare July 14, 2026 06:00
@abhichothani42
abhichothani42 changed the base branch from graphite-base/267 to vr-10-example-mobile July 14, 2026 06:00
Adds the EndEffectorPoseRecord data type and its protobuf schema for
recording end-effector pose alongside joint state in MCAP files.
Registers the new schema in CMakeLists.txt.
@abhichothani42
abhichothani42 force-pushed the eef-01-record-and-proto branch from b70c835 to 61fcb75 Compare July 17, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants