config: add robot description options to TrossenMCAP backend#273
Open
abhichothani42 wants to merge 2 commits into
Open
config: add robot description options to TrossenMCAP backend#273abhichothani42 wants to merge 2 commits into
abhichothani42 wants to merge 2 commits into
Conversation
This was referenced Jul 14, 2026
Collaborator
Author
This was referenced Jul 14, 2026
abhichothani42
marked this pull request as ready for review
July 14, 2026 06:10
There was a problem hiding this comment.
Pull request overview
Adds new configuration fields to the TrossenMCAP backend config so robot description recording behavior can be specified via JSON and --set overrides, in preparation for later backend wiring.
Changes:
- Extends
TrossenMCAPBackendConfigwithinclude_robot_description,include_meshes,robot_description_ref, andurdf_variant(with defaults). - Parses the new fields in
TrossenMCAPBackendConfig::from_json. - Forwards the new fields through
SdkConfig::populate_global_configintoGlobalConfig.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/configuration/sdk_config.cpp | Adds the new backend config fields to the JSON emitted into GlobalConfig. |
| include/trossen_sdk/configuration/types/backends/trossen_mcap_backend_config.hpp | Adds the new config surface and JSON parsing for robot description recording options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+59
to
+62
| if (j.contains("robot_description_ref")) { | ||
| j.at("robot_description_ref").get_to(c.robot_description_ref); | ||
| } | ||
| if (j.contains("urdf_variant")) j.at("urdf_variant").get_to(c.urdf_variant); |
Comment on lines
+55
to
+56
| if (j.contains("include_robot_description")) { | ||
| j.at("include_robot_description").get_to(c.include_robot_description); |
abhichothani42
force-pushed
the
urdf-02-backend-config
branch
from
July 17, 2026 14:48
ef8b5b5 to
a7e19c7
Compare
abhichothani42
force-pushed
the
urdf-01-description-cache
branch
from
July 17, 2026 14:48
56d0ee1 to
9344e57
Compare
abhichothani42
force-pushed
the
urdf-02-backend-config
branch
from
July 17, 2026 15:21
a7e19c7 to
a51dcee
Compare
abhichothani42
force-pushed
the
urdf-01-description-cache
branch
from
July 17, 2026 15:21
9344e57 to
0f981e8
Compare
abhichothani42
force-pushed
the
urdf-02-backend-config
branch
from
July 17, 2026 16:33
a51dcee to
7f15201
Compare
abhichothani42
force-pushed
the
urdf-01-description-cache
branch
from
July 17, 2026 16:33
0f981e8 to
584b9d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds the configuration surface for robot description recording. Nothing consumes these fields yet; the next PR wires them into the TrossenMCAP backend.
Changes
TrossenMCAPBackendConfig:include_robot_description(default off),include_meshes,robot_description_ref(git branch/tag, defaultmain), andurdf_variant(explicit repo path, empty = auto-resolve fromrobot_name).from_jsonand forward them throughSdkConfig::populate_global_config, so they work from JSON config and--setoverrides alike.Test Plan
make build)pre-commit run --all-files)Breaking Changes
None. All fields default to the previous behavior (no robot description written).
Related Issues
None.