Skip to content

config: add robot description options to TrossenMCAP backend#273

Open
abhichothani42 wants to merge 2 commits into
urdf-01-description-cachefrom
urdf-02-backend-config
Open

config: add robot description options to TrossenMCAP backend#273
abhichothani42 wants to merge 2 commits into
urdf-01-description-cachefrom
urdf-02-backend-config

Conversation

@abhichothani42

@abhichothani42 abhichothani42 commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds the configuration surface for robot description recording. Nothing consumes these fields yet; the next PR wires them into the TrossenMCAP backend.

Changes

  • Add four fields to TrossenMCAPBackendConfig: include_robot_description (default off), include_meshes, robot_description_ref (git branch/tag, default main), and urdf_variant (explicit repo path, empty = auto-resolve from robot_name).
  • Parse the new fields in from_json and forward them through SdkConfig::populate_global_config, so they work from JSON config and --set overrides alike.

Test Plan

  • Builds cleanly (make build)
  • Tests pass (make test)
  • Lint passes (pre-commit run --all-files)
  • Tested on hardware

Breaking Changes

None. All fields default to the previous behavior (no robot description written).

Related Issues

None.

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new configuration fields to the TrossenMCAP backend config so robot description recording behavior can be specified via JSON and --set overrides, in preparation for later backend wiring.

Changes:

  • Extends TrossenMCAPBackendConfig with include_robot_description, include_meshes, robot_description_ref, and urdf_variant (with defaults).
  • Parses the new fields in TrossenMCAPBackendConfig::from_json.
  • Forwards the new fields through SdkConfig::populate_global_config into GlobalConfig.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/configuration/sdk_config.cpp Adds the new backend config fields to the JSON emitted into GlobalConfig.
include/trossen_sdk/configuration/types/backends/trossen_mcap_backend_config.hpp Adds the new config surface and JSON parsing for robot description recording options.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +59 to +62
if (j.contains("robot_description_ref")) {
j.at("robot_description_ref").get_to(c.robot_description_ref);
}
if (j.contains("urdf_variant")) j.at("urdf_variant").get_to(c.urdf_variant);
Comment on lines +55 to +56
if (j.contains("include_robot_description")) {
j.at("include_robot_description").get_to(c.include_robot_description);
@abhichothani42
abhichothani42 force-pushed the urdf-02-backend-config branch from ef8b5b5 to a7e19c7 Compare July 17, 2026 14:48
@abhichothani42
abhichothani42 force-pushed the urdf-01-description-cache branch from 56d0ee1 to 9344e57 Compare July 17, 2026 14:48
@abhichothani42
abhichothani42 force-pushed the urdf-02-backend-config branch from a7e19c7 to a51dcee Compare July 17, 2026 15:21
@abhichothani42
abhichothani42 force-pushed the urdf-01-description-cache branch from 9344e57 to 0f981e8 Compare July 17, 2026 15:21
@abhichothani42
abhichothani42 force-pushed the urdf-02-backend-config branch from a51dcee to 7f15201 Compare July 17, 2026 16:33
@abhichothani42
abhichothani42 force-pushed the urdf-01-description-cache branch from 0f981e8 to 584b9d7 Compare July 17, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants