Skip to content

fix ten journal defects in the list, chooser and detail view - #1111

Open
vyagh wants to merge 10 commits into
masterfrom
journal-fixes
Open

fix ten journal defects in the list, chooser and detail view#1111
vyagh wants to merge 10 commits into
masterfrom
journal-fixes

Conversation

@vyagh

@vyagh vyagh commented Aug 16, 2026

Copy link
Copy Markdown
Member

While working on a larger Journal series, there were small unrelated bugs, so here they are as their own PR first.
One fix for a commit:

  • object chooser wasn't updating its list while it was open.
  • The filter toolbar's background was drawn over the whole surface instead of just its own box.
  • Entries made alone still showed a "Participants" heading, with nobody under it.
  • The list model still carried a column for selection that nothing uses anymore.
  • If an entry's title wasn't text, its row crashed instead of drawing.
  • The Journal could keep showing an outdated row: a half-made one after an error, or the old title after a rename (2 commits).
  • One file imported ListModel twice.
  • While typing in an entry's detail view, pressing Enter or the Left arrow threw you out of the text field instead of typing in it.
  • The list view found its title column by counting positions instead of using the reference it already has, which breaks the moment a column is added.

This is the base of a stacked series but merges fine on its own.

Two notes:

  1. make test is already red on master before this PR, and the journal test suite arrives in the next PR, not here.
  2. Tested by running the shell on a VM.

vyagh added 10 commits August 17, 2026 04:03
The == comparison read every visibility state backwards, so
the chooser's list stopped updating while it was on screen.
cr.paint() ignores the rectangle path and floods the whole
surface; cr.fill() honors it.
Solo entries carried an orphan Participants label over nothing.
Nothing reads COLUMN_SELECT; selection state lives in _selected.
GObject.markup_escape_text raises TypeError on anything that
is not a string, taking the whole row render down with it.
The cache index was set before the row was built, so an
exception mid-build left a half row served from cache on the
next read.
A rename kept serving the pre-edit row for the same index.
Return and the arrow keys resumed the activity or navigated
away while the child was typing in a text field.
get_column(3) breaks the moment columns are added or
reordered; the column object is already held.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant