fix ten journal defects in the list, chooser and detail view - #1111
Open
vyagh wants to merge 10 commits into
Open
fix ten journal defects in the list, chooser and detail view#1111vyagh wants to merge 10 commits into
vyagh wants to merge 10 commits into
Conversation
The == comparison read every visibility state backwards, so the chooser's list stopped updating while it was on screen.
cr.paint() ignores the rectangle path and floods the whole surface; cr.fill() honors it.
Solo entries carried an orphan Participants label over nothing.
Nothing reads COLUMN_SELECT; selection state lives in _selected.
GObject.markup_escape_text raises TypeError on anything that is not a string, taking the whole row render down with it.
The cache index was set before the row was built, so an exception mid-build left a half row served from cache on the next read.
A rename kept serving the pre-edit row for the same index.
Return and the arrow keys resumed the activity or navigated away while the child was typing in a text field.
get_column(3) breaks the moment columns are added or reordered; the column object is already held.
This was referenced Aug 16, 2026
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a larger Journal series, there were small unrelated bugs, so here they are as their own PR first.
One fix for a commit:
This is the base of a stacked series but merges fine on its own.
Two notes: