add timeline helpers and a row-facts cache for the journal views - #1112
Open
vyagh wants to merge 3 commits into
Open
add timeline helpers and a row-facts cache for the journal views#1112vyagh wants to merge 3 commits into
vyagh wants to merge 3 commits into
Conversation
Shared date math and drawing for the journal views.
One sitting groups the entries a child made in one stretch of work in the same activity.
Views ask for uid, timestamps and sitting key on every draw; answering from a cache avoids a result-set read per cell. Dates now run through timeline.safe_timestamp: zero or invalid timestamps render 'No date' instead of an 'Unknown' elapsed string, and nan/inf no longer raise.
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for the new Journal views that come later in this stack.
3 commits:
one visible change: an entry with a broken timestamp now shows "No date" instead of a date computed from timestamp 0.
Builds on #1111 , the list model changes here stack on the fixes there.
timeline.py is new, so it's registered in Makefile.am and POTFILES.in.
This PR also starts tests/journal: 76 tests pass here, plain unittest, no new dependency.
Also walked in the live shell on my dev VM.