redesign the journal entry page - #1120
Open
vyagh wants to merge 5 commits into
Open
Conversation
The journal surfaces tint the star with the child's own XO color; stock KeepIcon only ever drew the theme gray.
The redesign is two commits: this one lays the paper - the mount, moment minis, tag stickers, kept slips, and the geometry and CSS they are drawn from. Nothing calls them yet; the page moves onto them in the next commit.
The page moves onto the paper laid in the last commit: the work mounted, moments staged beside it, tags and kept lines as stickers, comments as cards, and room for the reflection rail. Field labels are re-keyed: eight msgids drop, eleven enter, and the comment-erase confirmation moves inline, replacing the alert.
Back and the talk toggle move into the toolbar; the journal wires them in the next commit. set_metadata syncs the toggle to where the child last put the rail this session.
DetailView stops packing the in-page BackBar (projectview keeps its own); back and the rail toggle live in the toolbar, and Jo's invite lands the page scrolled to the talk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expanded entry page rebuilt, navigation moved to the toolbar. Moments, tags, kept lines and comments get their own visual forms, with room at the side for the rail from #1119.
DetailView stops packing the in-page BackBar (projectview keeps its own), comment-erase confirms inline instead of an alert, and Jo's invite opens the page scrolled to the talk.
Builds on #1118 (card helpers) and #1119 (toolbar imports ReflectionView).
elsewhere.
No new tests or files (no view harness); suite unchanged, green.
VM Test: detail opens, toolbar back returns, rail opens with talk intact.
Series notes in #1111.