journal: scale chooser previews to classic cells - #1122
Open
vyagh wants to merge 1 commit into
Open
Conversation
Previews are stored at the toolkit's grown PREVIEW_SIZE (720x540); the chooser shows them at 5/12 so cells keep the classic 300x225. Needs the sugar-toolkit preview change first: against the older toolkit this would shrink chooser cells.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Journal chooser sizes its grid cells from the toolkit's PREVIEW_SIZE, so when sugarlabs/sugar-toolkit-gtk3#520 raises that constant to 720x540 the chooser's cells grow with it. This will render previews at 5/12 scale instead, so the chooser keeps its classic 300x225 cells.
Independent of the #1111 stack.
IMPORTANT :
It needs #520 merged first. This is the sugar-side follow-up mentioned in #520's description.
Testing:
the journal suite on my series branches (299 tests) passes with this change included; current master has no test covering the chooser renderer.