Repository navigation
Conversation
9e23bbd to
a63e021
Compare
|
Thank you for this. I worked on the same area in a fork and ran into a few multi-window cases that may be useful to check here. They come from my branch, so some may already be handled in this one:
#496 (closing the window or quitting asks to save unsaved workbooks) also changes close handling, so the two would need to be reconciled if both merge. |
|
Thanks for the detailed write-up! These all look relevant. I've moved this back to draft and marked it as blocked by #496 rather than building a competing close/quit flow. I'll rebase onto the latest main and work through the other points now: Apple Event routing and blank-window reuse, app-wide theme/language and preferences/recent files, and per-window egui state. Once #496 lands, I'll rebase again and adapt the multi-window close/quit path on top of it. |
a63e021 to
85b01eb
Compare
85b01eb to
a3ed811
Compare
e6d1e37 to
f6e52b1
Compare
Note
This overlaps with #496 in close/quit handling. Whichever lands second will need to rebase and reconcile that flow.
The egui state groundwork is also available independently in #662. Both branches now share the exact rebased
f79bf61commit, so either PR can merge first without creating a stacked dependency.Summary
Desktop behavior
The web app keeps its existing in-session document switching behavior.
Verification
cargo fmt --all -- --checkcargo test -p gridcraft(35 passed, including the macOS native-menu harness)cargo test -p gridcraft-ui-egui --test interaction(37 passed)cargo test -p gridcraft-ui-egui --test formula_popup(6 passed)cargo test -p gridcraft-ui-egui --test keyboard_shortcuts(8 passed)cargo test -p gridcraft-ui-egui --test workbook_widget_state(1 passed)cargo xtask wasmcargo xtask assetscargo xtask layerscargo xtask parity --checkcargo xtask keytips --checkThe full
cargo xtask cirun currently stops on Rust 1.95 Clippy warnings in untouched latest-main XLS code. A full workspace test run also reaches unrelated existing failures in CSV number formatting, one missing French translation, and the sandboxed MCP TCP test; the changed app and UI tests pass.Fixes #162