Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
srudraDev
force-pushed
the
ui/multiple-workbook-windows
branch
from
October 11, 2026 00:33
d7a180a to
0312359
Compare
Contributor
|
Hey, nice work! I somehow missed this before starting #171, so we’ve ended up exploring two different approaches to the same problem. Sorry about the duplicate work. I like how small and straightforward this implementation is. It gives each workbook a real native window by launching a separate GridCraft process. In #171 I took the other route: multiple native egui windows coordinated inside one process. That adds more lifecycle work, but it means GridCraft can:
|
2 of 3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening another workbook from an existing native GridCraft window now launches
it in a separate native window, preserving the current workbook.
open_in_new_windowhost service for desktop shells.unreadable files report an error in the current UI.
relative, absolute, and canonical paths.
service is provided.
Validation
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo test -p gridcraft-ui-eguicargo check -p gridcraftcargo check -p gridcraft-web --target wasm32-unknown-unknowngit diff --check