Repository navigation
Move or copy self-contained worksheets between workbooks - #1803
Open
derechopiano wants to merge 1 commit into
Open
derechopiano wants to merge 1 commit into
derechopiano wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an open-workbook picker and a new-workbook destination to Move or Copy. A self-contained worksheet transfers with its cell data, formulas, formatting, ordinary tables and supported sheet features. Sheet-name collisions are resolved without rebinding self-references to an unrelated destination sheet.
Transfers validate first, then publish the results. Styles are interned into the destination, local names and required workbook names are imported, and tables receive new ids. A move has linked undo/redo entries in both documents: later edits or a closed participant prevent a partial undo.
This is deliberately a safe first implementation, not cross-workbook formula-link infrastructure. Transfers requiring unsupported links, conflicting names, different date systems/themes, VBA, retained package content, connected/XML tables, PivotTables or slicers are refused with an error. Moving data used by another source report is also refused. Neither file is saved automatically. Full scope and command parameters are in
docs/sheet-transfer.md.Validation:
cargo xtask ci: all eight stages passed (fmt, Clippy, workspace tests, assets, layers, WASM, parity and keytips). The successful run includes local-loopback tests outside the agent sandbox.Related work: #171 proposes separate workbook windows and #662 scopes UI state by workbook. This PR uses the current
Sessiondocument model and stable document uids; cross-window document ownership will need reconciliation if #171 lands first. It does not duplicate that window-management work.Related to #1739. Unsupported workbook-link cases are intentionally left for follow-up rather than silently damaging formulas or dropping content.