Repository navigation
Introduce compression publication to ROS 2 camera - #1067
Merged
Merged
Conversation
michalpelka
force-pushed
the
mp/compression
branch
from
July 28, 2026 15:59
32d2bcd to
4bef139
Compare
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
force-pushed
the
mp/compression
branch
from
July 28, 2026 16:20
4bef139 to
8681ff5
Compare
byrcolin
added
the
sig/simulation
michalpelka
force-pushed
the
mp/compression
branch
2 times, most recently
from
July 30, 2026 10:50
466d034 to
66391d4
Compare
- modified UX to ROS2ImageEncodingConversionComponent - it now allows to choose conversion - added to ROS2ImageEncodingConversionComponent depth32F1 -> mono16/mono8 - moved conversion code out of component for reuse in other components - added runtime fallback to ROS2ImageCompressionComponent (float to mono16) - added automatically generated tests. Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
force-pushed
the
mp/compression
branch
from
July 30, 2026 11:40
66391d4 to
f6dc50d
Compare
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
…essionEditorComponent.cpp Co-authored-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
…essionComponent.cpp Co-authored-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
…essionComponent.h Co-authored-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Contributor
Author
|
@jhanca-robotecai thank you for your review, applied all your comments except one, that I do not understand. |
jhanca-robotecai
requested changes
Aug 19, 2026
jhanca-robotecai
left a comment
jhanca-robotecai
left a comment
Collaborator
There was a problem hiding this comment.
- the code does not build with ROS 2 Lyrical
- JPEG is disabled (I assume debug leftover)
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
…on.cpp Co-authored-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
…codingConversionComponent.h Co-authored-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
jhanca-robotecai
approved these changes
Aug 19, 2026
This was referenced Aug 31, 2026
jhanca-robotecai
added a commit
that referenced
this pull request
Sep 8, 2026
* Introduce compression publication to ROS 2 camera (#1067) * Use O3DE's 3rdParty convention for ROS 2 package dependencies to survive in Prebuilt Gems (#1066) * Upgrade Tracy profiler to 1.14.1, also mark the tracy frame end to RHI OnFrameEnd. (#1090) * Add workflow to test simulation Gems for PR (#1089) --------- Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Ross Charles C. <10781734+rossbridger@users.noreply.github.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai> Co-authored-by: Mateusz Żak <mateusz.zak@robotec.ai> Co-authored-by: Ross Charles C. <10781734+rossbridger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduce compression to ROS 2 camera.
New UX of ROS2ImageEncodingConversionComponent
In development was bug that prevented user getting back from invalid config. I've changed it to message, that user is about shoot themself in foot:
ROS2ImageCompressionEditorComponent
I also do not prevent user from trying to compress depth with JPEG (what makes no sense in any application).
How was this PR tested?