W104.5 - Record the compatibility sweep's existing in-repo evidence - #449
Merged
Conversation
…proves The sweep's lint/test steps already re-verify the text client and MCP server on every run: the client-boundary ESLint rule catches a kind import, and their own API-coverage suites exercise every SessionStore operation. Neither is a published export, so there is no separate packed-archive step for them the way consumer-smoke has one. Static host, Adventures, and the service-contract generator stay unverifiable from this repository, same as #391 recorded for W103.7.
7 tasks
11 passed, 4 did-not-run (docs.ps1 absent, docs-build artifact absent, REGISTRY_TOKEN unavailable for the two host-image smoke gates). No gate failed.
4 tasks
The-Running-Dev
added a commit
that referenced
this pull request
Sep 7, 2026
… current engine (#452) Manually packed the engine at e52e7a1 and re-vendored the tarball into SubZeroDev.Platform's game-service workload, SubZeroDev.ServiceContract, and SubZeroDev.Adventures (submodule bumped to the same commit). All three consumers' own test suites pass unchanged: ServiceContract (59), Platform's game-service including its dependency-direction surface guard and durable Postgres profile (197, 1 pre-existing skip), and Adventures' lint/typecheck/test/test:browser/test:build (274). None reach past the declared SessionStore/Portable*/fromPortable surface. Sibling checkouts were left exactly as found (bump reverted after verification); evidence recorded on issue #392. This closes the last unmet W104 criterion — text client and MCP server were already proven in-repo by PR #449.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
W104's only remaining acceptance criterion is W104.5:
Of its four named consumers, three live in repositories not present here
(SubZeroDev.Platform for the static host, SubZeroDev.Adventures, and the
service-contract generator) and stay unverifiable from this repository — the
same cross-repo limit issue #391 recorded for W103.7.
The remaining two — the text client and the MCP server — already live in this
repository, and their compliance was already fully proven by existing gates
that run on every commit:
eslint.config.js's client-boundary rule (src/clients/**,src/mcp/**)fails the build if either imports a kind directly instead of calling only
SessionStore— the "use only the declared surface" half.src/clients/text/client.test.tsandsrc/mcp/server.test.tsexercise thefull 09-clients.md §4 API-coverage checklist against a real store — the
"pass" half.
Neither is a published export (
package.json'sexportsmap has only.and
./authoring), so there is no meaningful "against the packed archive"step for them distinct from what the sweep already runs — unlike
consumer-smoke/, which does consume the packed tarball for the publishedsurface.
This PR makes that evidence explicit in
Test-CompatibilitySweep.ps1's owndoc comment, so a reader of the sweep's output can see which part of W104.5
it already closes and which three consumers remain out of reach from here.
No behavior change:
lintandtestalready ran these checks before thisPR. It also commits
.claude/verify-report.json, the structured gate report/verifyproduced for this branch (see Verified below).Verified
Ran and passed:
tsc --noEmit && tsc --noEmit -p tsconfig.scripts.jsonexited 0 with no output.eslint src scriptsexited 0 with no output.Test Files 97 passed (97),Tests 1594 passed (1594), duration 8.88s.npm pack --silentinsrc/engineproducedthe-running-dev-game-engine-0.10.0.tgzwith no errors.(^|/)src/, notsconfig*.jsonentries, no.test.(js|mjs|ts|d.ts|*.map)entries, andpackage/dist/is present.consumer-smoke/:npm ci,npm run install:engineagainst the packed tarball,npm run build,npm run smokeall exited 0 with no assertion failures.*.ps1parsed clean via[System.Management.Automation.Language.Parser]::ParseFile;ALL PARSE OK.Tests Passed: 324, Failed: 0, Skipped: 35, NotRun: 0../build/Test-Documentation.ps1: "Human-documentation drift check passed across 18 generated engine page(s), compatibility pointers, and the guide." and "Documentation checks passed across 197 Markdown file(s)."npm --prefix src/engine run buildthennpm --prefix site run check(format, lint, typecheck, unit test, browser test, build+verify, merge-verify) all passed.dotnet test ... -c Release:Passed! - Failed: 0, Passed: 12, Skipped: 0, Total: 12.Ran and failed: none.
Did not run:
docs.ps1is not present in this checkout (perCLAUDE.md, it's installed byInvoke-SetupDocsand not committed), so the Docusaurus production build cannot be reproduced locally even though Docker is available. The Verify Documentation Build check on this PR is the authority for this gate.../artifacts/docs, the output of the unavailable documentation build above; that directory does not exist locally, so there is nothing to merge into.REGISTRY_TOKENcross-repo credential (to restoreSubZeroDev.Platform.Hostingfrom GitHub Packages) that is not available locally. The Platform Static Host Image check on this PR is the authority for this gate.Test plan
from
src/clients/**orsrc/mcp/**(unchanged by this PR; verifiedby reading
eslint.config.js:59-83).client.test.ts/server.test.tsstill exercise everySessionStoreoperation (unchanged; confirmed vianpm test).Out of scope
Verifying the static host, Adventures, or the service-contract generator —
none live in this repository. W104.5 stays open until that cross-repo
coordination happens.