W104.5 — Verify static host, Adventures, and service-contract against current engine - #452
Merged
Conversation
… current engine Manually packed the engine at e52e7a1 and re-vendored the tarball into SubZeroDev.Platform's game-service workload, SubZeroDev.ServiceContract, and SubZeroDev.Adventures (submodule bumped to the same commit). All three consumers' own test suites pass unchanged: ServiceContract (59), Platform's game-service including its dependency-direction surface guard and durable Postgres profile (197, 1 pre-existing skip), and Adventures' lint/typecheck/test/test:browser/test:build (274). None reach past the declared SessionStore/Portable*/fromPortable surface. Sibling checkouts were left exactly as found (bump reverted after verification); evidence recorded on issue #392. This closes the last unmet W104 criterion — text client and MCP server were already proven in-repo by PR #449.
7 tasks
1 task
The-Running-Dev
added a commit
that referenced
this pull request
Sep 7, 2026
The committed report was stale against src/engine's current typecheck/lint/test output wording and was missing two gates (Test-Companion.ps1, Test-DesignState.ps1) that PR #452's /verify pass discovered. Replaces it with that pass's validated 17-gate report (12 passed, 0 failed, 5 did-not-run with reasons), matching what was already posted verbatim in PR #452's description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the last unmet W104 (Release 0.11 Compatibility Sweep) criterion. Text client and MCP server were already proven in-repo by PR #449; this closes the remaining three named consumers — the static host, Adventures, and the service-contract generator — which live outside this repository.
e52e7a1(npm packfromsrc/engine, sha256ef934530...aa2a2) and manually re-vendored the tarball into three sibling checkouts on this machine: SubZeroDev.Platform'sgame-serviceworkload, SubZeroDev.ServiceContract, and SubZeroDev.Adventures (engine submodule bumped to the same commit).dependency-direction.test.ts(static AST guard: no runtime import of the engine package reaches the store) passed; full suite 197/198 (1 pre-existing skip) including the durable Postgres profile viadocker compose.test(198),test:browser(38),test:buildall green with the submodule ate52e7a1. (format:checkfails only on pre-existing unrelated clutter files already tracked in that repo — confirmed viagit statusthat nothing else in the tree changed besides the submodule pointer.)SessionStore/Portable*/fromPortablesurface — confirmed by Platform's own automated guard and Adventures' single, pre-existing, explicitly-commented non-contract import (shared/campaign-registry.ts).Closes #392
Changes
build/Test-CompatibilitySweep.ps1: corrected the sweep's docstring, which claimed these three consumers "stay unverified here" — they've now been verified manually, with the evidence recorded on issue W104 — Release 0.11 Compatibility Sweep #392 and the point-in-time nature of that proof noted (it needs re-running whenever any of the three repos re-vendors this engine).Verified
Ran and passed:
npm --prefix src/engine run typecheck, no errorsnpm --prefix src/engine run lint, no findingsnpm --prefix src/engine test, 97 files / 1594 tests, all passednpm pack --silent, tarball produced cleanlysrc/, notsconfig*.json, no.test.*build artifacts,package/dist/presentconsumer-smoke/: install, build, and smoke against the fresh tarball, clean*.ps1in the repo, zero parse errorstools/Test-Companion.ps1: Valid, 23 core / 14 companion / 9 with no companion./build/Test-Documentation.ps1: 18 generated engine pages plus compatibility pointers and the guide, and 197 Markdown files, all passnpm --prefix site run check(format/lint/typecheck/test [15]/test:browser [11]/test:build/test:merge), all greendotnet test src/host/.../Host.Tests.csproj -c Release: 12/12 passedRan and failed: none
Did not run:
tools/Test-DesignState.ps1exited 2 (could-not-evaluate, not a finding):ContractListUnreadable: SectionNotFound: design/20-contract.mdandStateSetAbsent: design/state/ is missing or holds no records other than WorkRef mirrors— this repository has not adopteddesign/state/as its live state setdocs.ps1is not present in this checkout (installer-generated, not committed, perCLAUDE.md); the production Docusaurus build needs it plus Docker. The "Verify Documentation Build" check on this PR is where this answer comes fromartifacts/docsfrom the "Build documentation" step above, which did not run;npm --prefix site run mergefails with "has no protected docs subtree" for exactly that reasonREGISTRY_TOKEN(a CI-only secret) to restoreSubZeroDev.Platform.Hostingand build the host Docker image; not available locally. The "Platform Static Host Image" check on this PR is where this answer comes fromTest plan
src/enginetypecheck/lint/test passAgent detail
design/30-slices.md§ W104 @e52e7a1