Repository navigation
Conversation
Add the ELFIO 3.12 backport for bounded note parsing while the upstream fix is reviewed in serge1/ELFIO#173. Refs: SWSPLAT-24318
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🎉 All checks passed! This PR is ready for review. |
therock-pr-bot
Bot
removed
the
Not ready to Review
1 task done
Synchronize the ELFIO 3.12 note accessor updates with upstream and simplify patch notes. Refs: SWSPLAT-24318
1 task done
Rebase the backport onto serge1/ELFIO#173 at 5aaee4f. Adds acceptance of owner names without a terminator, a zero descriptor size for notes added without data, 4-byte alignment of notes added after unaligned data, and a rescan in add_note() so cached indices stay consistent with a fresh accessor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Backport ELFIO #173 to TheRock's pinned ELFIO 3.12.
JIRA ID: SWSPLAT-24318
Technical Details
Ports serge1/ELFIO#173 at
5aaee4fto ELFIO 3.12 (on top of the existing0001patch). The changes:readelfdoes). Outputs are left unchanged on validation failure.add_note()records a zero descriptor size whendescis null, and pads existing data to a 4-byte boundary before appending. When the existing data did not decode completely, it rescans, so the accessor's note indices match a fresh accessor's.The public API is unchanged. Compared with the upstream PR, only the 3.12 adaptations differ: the convertor is a reference rather than a pointer, and comments follow 3.12 style.
Remove the patch when upgrading to an ELFIO release containing the upstream change.
Test Plan
patch_third_party_source.pyto a freshelfio-3.12.tar.gz(SHA512 matchingthird-party/elfio), together with [SWSPLAT-24296] Backport ELFIO hash table bounds validation #7772's symbol patch.tests/elf_examples, patched vs. unpatched 3.12.Test Result
startup.eln/startup_orig.elnnow return their full owner name (Freescale Semiconductor) instead of a truncated one.Submission Checklist
Prepared with AI assistance.
🤖 Generated with Claude Code