Repository navigation
Conversation
Disable the SDK's internal ELFIO build and declare therock-elfio as a build dependency so package discovery uses TheRock's managed headers.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The committed consumer graph must be regenerated to include the new dependency edge.
1 open finding
What changed in this PR
Routes rocprofiler-sdk to TheRock’s patched ELFIO package.
Changes:
- Disables rocprofiler-sdk’s bundled ELFIO build.
- Adds
therock-elfioas a build dependency.
| File | Description |
|---|---|
profiler/CMakeLists.txt |
Configures rocprofiler-sdk to consume TheRock’s ELFIO package. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+135
to
+136
| BUILD_DEPS | ||
| therock-elfio |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The SDK currently builds its own ELFIO submodule, bypassing the copy managed and patched by TheRock.
Technical Details
Set
ROCPROFILER_BUILD_ELFIO=OFFand addtherock-elfioas a build dependency so the SDK resolves ELFIO through TheRock's package provider.This allows the SDK to consume the ELFIO updates in #7772 and #7773 once those backports land.
JIRA ID: SWSPLAT-24296
JIRA ID: SWSPLAT-24318
Test Plan
Run pre-commit checks and inspect the dependency configuration. During integration testing, build rocprofiler-sdk and confirm its compiler include paths use TheRock's ELFIO package.
Test Result
git diff --checkpassed.Submission Checklist
Prepared with AI assistance.