Repository navigation
Conversation
Reject invalid note indices and truncated or malformed padded note records before returning their fields or payloads. Refs: SWSPLAT-24318
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Use consistent record validation for scanning and retrieval, including owner string termination, while retaining nameless note support. Refs: SWSPLAT-24318
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix note indexing and parsing in CLR's embedded ELFIO copy, which is maintained separately from upstream.
Technical Details
Related: upstream ELFIO #173 and TheRock backport #7773.
Issue Tracking
JIRA ID: SWSPLAT-24318
Test Plan
Run local ELF32/ELF64 checks in both byte orders, covering invalid indices, record boundaries, owner names, data mutation, and serialized inputs.
Test Result
Local checks passed with MSVC ASan and GCC ASan/UBSan.
Submission Checklist
Prepared with AI assistance.