Repository navigation
Conversation
Add the ELFIO 3.12 backport for bounded SysV and GNU hash lookup while the upstream fix is reviewed in serge1/ELFIO#174. Refs: SWSPLAT-24296
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
1 task done
Align the ELFIO 3.12 lookup updates with upstream and simplify the patch notes. Refs: SWSPLAT-24296
1 task done
Rebase the backport onto serge1/ELFIO#174 at c6e67fa. Adds authoritative misses on well-formed SysV and GNU hash tables (local and unhashed symbols are still searched linearly), rejection of non-power-of-two bloom sizes, output parameters written only on a match, and alignment-safe symbol record access including arrange_local_symbols(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Backport ELFIO #174 to TheRock's pinned ELFIO 3.12.
JIRA ID: SWSPLAT-24296
Technical Details
Ports serge1/ELFIO#174 at
c6e67fato ELFIO 3.12 (on top of the existing0001patch). The changes:memcpy, including inarrange_local_symbols().The public API is unchanged. Compared with the upstream PR, only the 3.12 adaptations differ: the convertor is a reference rather than a pointer, plain
uint32_tis used, and doc comments follow 3.12 style.Remove the patch when upgrading to an ELFIO release containing the upstream change.
Test Plan
patch_third_party_source.pyto a freshelfio-3.12.tar.gz(SHA512 matchingthird-party/elfio).tests/elf_examplesby name, patched vs. unpatched 3.12.Test Result
Submission Checklist
Prepared with AI assistance.
🤖 Generated with Claude Code