Skip to content

Handle simulation edge cases safely - #385

Closed
galjos wants to merge 8 commits into
devfrom
fix/simulation-edge-cases
Closed

Handle simulation edge cases safely#385
galjos wants to merge 8 commits into
devfrom
fix/simulation-edge-cases

Conversation

@galjos

@galjos galjos commented Jul 28, 2026

Copy link
Copy Markdown
Member

Fixes five simulation edge cases: AppleClang destruction of ParameterFileReader, invalid cell-list dimensions, single-step progress output, zero-temperature rescaling, and temperature ramps with a partial final interval. Invalid ramp schedules are rejected before thermostat state is changed.

Validated by eight focused test targets.

Closes #379.

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.84%. Comparing base (e93036c) to head (58c98bd).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #385      +/-   ##
==========================================
+ Coverage   89.81%   89.84%   +0.03%     
==========================================
  Files         293      293              
  Lines       11421    11458      +37     
  Branches     3601     3617      +16     
==========================================
+ Hits        10258    10295      +37     
  Misses       1122     1122              
  Partials       41       41              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pq-perf-bot

pq-perf-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚡ Performance (instruction count) — ✅ no regressions

per-benchmark breakdown
benchmark base Ir PR Ir Δ
bondedForces 41.46M 41.46M -0.00%
boxTransforms 10.67M 10.67M +0.00%
constraints 11.38M 11.38M -0.00%
coulombKernel 5.80M 5.80M +0.00%
forceKernel 15.33M 15.33M +0.00%
integrator 32.17M 32.17M -0.00%
kinetics 9.53M 9.53M +0.00%
linearAlgebra 2.07M 2.07M +0.00%
nonCoulombPairs 5.48M 5.48M -0.00%
shiftVector 5.81M 5.81M +0.00%
virial 11.64M 11.63M -0.07%

Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock.

@97gamjak 97gamjak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

olease split this Pr into single PRs

@galjos galjos closed this Jul 30, 2026
@galjos
galjos deleted the fix/simulation-edge-cases branch August 4, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants