Skip to content

fix: complete single-step progress bars - #349

Merged
97gamjak merged 5 commits into
devfrom
fix/single-step-progressbar
Aug 4, 2026
Merged

fix: complete single-step progress bars#349
97gamjak merged 5 commits into
devfrom
fix/single-step-progressbar

Conversation

@galjos

@galjos galjos commented Jul 28, 2026

Copy link
Copy Markdown
Member

Closes #344.

Return 100% for a one-cycle progress bar without dividing by zero.

Tests:

  • testProgressbar

@galjos
galjos requested review from 97gamjak and ape33 July 28, 2026 15:46
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.82%. Comparing base (a15094d) to head (23dd5bc).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #349   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files         293      293           
  Lines       11479    11479           
  Branches     3600     3600           
=======================================
  Hits        10311    10311           
  Misses       1126     1126           
  Partials       42       42           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pq-perf-bot

pq-perf-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚡ Performance (instruction count) — ✅ no regressions

per-benchmark breakdown
benchmark base Ir PR Ir Δ
bondedForces 41.46M 41.46M -0.00%
boxTransforms 10.67M 10.67M +0.00%
constraints 11.38M 11.38M -0.00%
coulombKernel 5.80M 5.80M +0.00%
forceKernel 15.33M 15.33M +0.00%
integrator 32.17M 32.17M -0.00%
kinetics 9.53M 9.53M +0.00%
linearAlgebra 2.07M 2.07M +0.00%
nonCoulombPairs 5.48M 5.48M -0.00%
shiftVector 5.81M 5.81M +0.00%
virial 11.64M 11.63M -0.07%

Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock.

Comment thread external/progressbar/include/progressbar.hpp
@galjos galjos reopened this Jul 30, 2026
@galjos
galjos requested a review from 97gamjak July 30, 2026 11:03
@97gamjak
97gamjak merged commit d89f87b into dev Aug 4, 2026
15 checks passed
@97gamjak
97gamjak deleted the fix/single-step-progressbar branch August 4, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants