fix: complete partial temperature ramps - #351
Open
galjos wants to merge 7 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #351 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 291 291
Lines 11535 11543 +8
Branches 3601 3606 +5
=======================================
+ Hits 10362 10370 +8
Misses 1131 1131
Partials 42 42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
⚡ Performance (instruction count) — ✅ no regressionsper-benchmark breakdown
Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock. |
97gamjak
requested changes
Jul 28, 2026
…pdates # Conflicts: # tests/src/setup/testThermostatSetup.cpp
ape33
requested changes
Aug 5, 2026
ape33
left a comment
Member
There was a problem hiding this comment.
see comment, otherwise approved
Comment on lines
222
to
223
| * If the start temperature is defined, the temperature ramp is enabled. | ||
| ** |
Member
There was a problem hiding this comment.
please also update the formatting of this comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #341.
Tests: