Skip to content

fix: validate cell-list dimensions - #348

Open
galjos wants to merge 5 commits into
devfrom
fix/cell-list-size-guards
Open

fix: validate cell-list dimensions#348
galjos wants to merge 5 commits into
devfrom
fix/cell-list-size-guards

Conversation

@galjos

@galjos galjos commented Jul 28, 2026

Copy link
Copy Markdown
Member

Closes #346.

  • reject zero cell-list dimensions
  • reject cumulative size overflow before allocation

Tests:

  • testCelllist

@galjos
galjos requested review from 97gamjak and ape33 July 28, 2026 15:46
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.83%. Comparing base (a15094d) to head (68521b9).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #348   +/-   ##
=======================================
  Coverage   89.82%   89.83%           
=======================================
  Files         293      293           
  Lines       11479    11490   +11     
  Branches     3600     3603    +3     
=======================================
+ Hits        10311    10322   +11     
  Misses       1126     1126           
  Partials       42       42           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pq-perf-bot

pq-perf-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚡ Performance (instruction count) — ✅ no regressions

per-benchmark breakdown
benchmark base Ir PR Ir Δ
bondedForces 41.46M 41.46M -0.00%
boxTransforms 10.67M 10.67M +0.00%
constraints 11.38M 11.38M -0.00%
coulombKernel 5.80M 5.80M +0.00%
forceKernel 15.33M 15.33M +0.00%
integrator 32.17M 32.17M -0.00%
kinetics 9.53M 9.53M +0.00%
linearAlgebra 2.07M 2.07M +0.00%
nonCoulombPairs 5.48M 5.48M -0.00%
shiftVector 5.81M 5.81M +0.00%
virial 11.64M 11.63M -0.07%

Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock.

@galjos galjos reopened this Jul 30, 2026
Comment thread src/simulationBox/celllist.cpp Outdated
@galjos
galjos requested a review from 97gamjak August 1, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants