Merge LTS to Latest by Abadima · Pull Request #10 · Abadima/simply-xp

Abadima · 2026-01-26T03:36:51Z

No description provided.

DEPENDENCY UPDATES: - @napi-rs/canvas => v0.1.41 - mongoose => v7.4.2 BUG FIXES: - xp.rank() error - xp.chart() now has a helpful err message - leaderboard() Position & Cache issues TYPE IMPROVEMENTS: - addLevel() => Make Code Prettier - addXP() => Make Code Prettier - charts() => Make Code Prettier - leaderboard() => Ensured limit was optional for TypeScript users - rank() => Cure Cancer (Remove Unnecessary Statements) UPDATES: - Added eslint (dev) - rank() => Moved Funcs (eslint compliant) - connect() => "auto_purge" option, basically does what it did in Beta 7, but you have a choice (false by default)

Bug Fixes

⭐ Improvements - Refactor leaderboard and rank position calculation into a new utility for efficiency and code reuse. - Add a compound index to the level model for improved leaderboard query performance. - Improve leaderboard auto-purge logic and cleaned up code style. - Refactor `rank()` image to scale background images properly, fixing stretching issues. 💎 Design Changes - Replace `Baloo-Regular.ttf` to `Baloo2-Regular.woff2` for better performance and smaller size. ⬆️ Dependencies - Bump `@napi-rs/canvas` from `v0.1.43` to `v0.1.88`.

Extracted level up notification and XP shortener functions into separate utility modules for better code reuse and maintainability. Updated addLevel, setLevel, fetch, leaderboard, and rank modules to use these utilities. Also simplified ESLint config file patterns and bumped package version to 1.3.8-fix.0.

Extracted the repeated level payload construction logic from addLevel.js and setLevel.js into a new utility function, buildLevelPayload, in src/utils/levelPayload.js. This improves code reuse and maintainability.

codacy-production · 2026-01-26T04:09:48Z

Codacy's Analysis Summary

100 new issues (≤ 0 medium issue)
1 new security issue (≤ 0 issue)
13 complexity
-15 duplications

Review Pull Request in Codacy →

✨ AI Reviewer available: add the codacy-review label to get contextual insights without leaving GitHub.

Improved leaderboard logic for robustness and variable clarity. Added JSDoc comments to utility functions for better documentation. Minor cleanup in addLevel and setLevel by removing unused variables. Updated README with new badges and improved formatting.

Improves leaderboard entry handling by cloning objects before destructuring, enhancing data safety. Refactors shortener to handle non-numeric input and index bounds more robustly. Updates README for improved clarity and formatting.

Updated leaderboard position calculation to use entryIndex for accuracy and refactored the loop to use for...of. Improved shortener function by safely handling suffix assignment. Also standardized formatting and type definitions in index.d.ts for consistency.

Abadima · 2026-01-26T04:37:21Z

I give up trying to please codacy, there isn't a way to do it rn without creating really silly looking code, even with copilot's assistance

Copilot

Pull request overview

This PR appears to modernize the codebase (“Merge LTS to Latest”) by refactoring shared XP/leveling utilities, adjusting leaderboard/rank computation, and updating project metadata/tooling.

Changes:

Added shared utility modules (short number formatting, level-up notification, leaderboard position lookup).
Refactored rank/leaderboard/fetch logic to use shared helpers and added a DB index for guild XP sorting.
Updated package metadata (deps, eslint config, docs/readme, ignore files) and introduced a module-level options config.

Reviewed changes

Copilot reviewed 25 out of 29 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/utils/shortener.js	New shared number-shortening helper.
src/utils/levelUpNotifier.js	New helper to emit `levelUp` with resolved role config.
src/utils/levelPayload.js	New helper to standardize `levelUp` payload shape.
src/utils/getUserPosition.js	New cursor-based helper to compute leaderboard position without loading whole list.
src/setXP.js	Refactors XP set logic to use `findOneAndUpdate`.
src/setLevel.js	Refactors level set logic and extracts notification/payload creation.
src/roleSetup.js	Formatting/string consistency updates.
src/reset.js	Formatting update of errors and query call.
src/rank.js	Uses shared shortener + position helper; rank card rendering refactor.
src/models/lvlrole.js	Formatting/string consistency updates.
src/models/level.js	Adds `{ guild, xp }` index; formatting updates.
src/lvlRole.js	Formatting/string consistency updates.
src/leaderboard.js	Reworks leaderboard construction and adds optional auto-purge behavior.
src/fetch.js	Uses shared shortener + position helper.
src/create.js	Formatting update of errors and DB insert behavior.
src/connect.js	Formatting changes and modifies notify behavior.
src/charts.js	Switches to `@napi-rs/canvas` usage and formatting updates.
src/addXP.js	Formatting/string consistency updates.
src/addLevel.js	Uses new payload/notifier helper instead of inline emission logic.
src/Fonts/Baloo2-Regular.woff2	Adds new font asset used by rank card.
simplyxp.js	Adds exported `options` object and standardizes require/export formatting.
package.json	Updates version/metadata, dependencies, scripts, keywords, and repo links.
index.d.ts	Reformats typings and adjusts some option types.
eslint.config.cjs	Adds ESLint flat config (replaces `.eslintrc.json`).
README.md	Updates badges, copy, and formatting.
.npmignore	Expands ignored files for publishing.
.gitignore	Updates ignored files (pnpm lock/workspace).
.eslintrc.json	Removes legacy ESLint config.

Comments suppressed due to low confidence (1)

src/models/level.js:6

The schema marks user as globally unique, but all queries in this package are keyed by { user, guild }. This uniqueness constraint will prevent the same user from having XP in multiple guilds. Consider removing unique: true on user and adding a compound unique index on { user: 1, guild: 1 } instead.

const Levelz = new mongoose.Schema({
	user: { type: String, unique: true },
	guild: { type: String },
	xp: { type: Number, default: 0 },

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Allow xp = 0 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Remove unnecessary const Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-01-26T04:53:31Z

@Abadima I've opened a new pull request, #11, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>

Fix levelUp event emission logic in addLevel

Copilot · 2026-01-26T04:59:19Z

@Abadima I've opened a new pull request, #12, to work on those changes. Once the pull request is ready, I'll request review from you.

codacy-production · 2026-01-26T05:07:43Z

Codacy's Analysis Summary

100 new issues (≤ 0 medium issue)
0 new security issue (≤ 0 issue)
21 complexity
-15 duplications

Review Pull Request in Codacy →

✨ AI Reviewer available: add the codacy-review label to get contextual insights without leaving GitHub.

Fix setLevel to capture previous level before update

Fix type coercion in setLevel to prevent incorrect event emission

Copilot

Pull request overview

Copilot reviewed 25 out of 29 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-26T05:24:33Z

+async function notifyLevelUp(message, data, roleLevel) {
+    const role = await roleSetup.find(message.client, data.guildID, roleLevel);
+    message.client.emit("levelUp", message, data, role);
+}


Indentation here uses spaces instead of tabs, which will fail the repo’s ESLint indent: ["error", "tab"] rule.

Abadima · 2026-01-26T05:25:14Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-01-26T05:25:22Z

@Abadima I've opened a new pull request, #15, to work on those changes. Once the pull request is ready, I'll request review from you.

…n, member checks, and logging Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>

Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>

Fix level emission, negative number handling, and member validation issues

Abadima · 2026-01-26T05:39:50Z

@copilot your suggestions have been granted, plz approve review

Copilot · 2026-01-26T05:39:59Z

@Abadima I've opened a new pull request, #16, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 25 out of 29 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Abadima · 2026-01-26T05:49:09Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-01-26T05:49:16Z

@Abadima I've opened a new pull request, #17, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>

[WIP] Merge LTS to latest code version

codacy-production · 2026-01-26T05:54:11Z

Codacy's Analysis Summary

100 new issues (≤ 0 medium issue)
0 new security issue (≤ 0 issue)
29 complexity
-13 duplications

Review Pull Request in Codacy →

✨ AI Reviewer available: add the codacy-review label to get contextual insights without leaving GitHub.

Abadima added 6 commits August 6, 2023 22:47

*quick updates

b50ac7a

v1.3.7

8922663

Bug Fixes

Refactor level payload creation to utility function

b9c0d22

Extracted the repeated level payload construction logic from addLevel.js and setLevel.js into a new utility function, buildLevelPayload, in src/utils/levelPayload.js. This improves code reuse and maintainability.

Repository owner deleted a comment from codacy-production Bot Jan 26, 2026

Abadima added 4 commits January 25, 2026 23:20

Refactor leaderboard and shortener logic

3018380

Improves leaderboard entry handling by cloning objects before destructuring, enhancing data safety. Refactors shortener to handle non-numeric input and index bounds more robustly. Updates README for improved clarity and formatting.

is it fixed yet..

732fccb

Updated leaderboard position calculation to use entryIndex for accuracy and refactored the loop to use for...of. Improved shortener function by safely handling suffix assignment. Also standardized formatting and type definitions in index.d.ts for consistency.

Update shortener.js

59bb447

Abadima requested a review from Copilot January 26, 2026 04:36

Copilot started reviewing on behalf of Abadima January 26, 2026 04:37 View session

Copilot AI reviewed Jan 26, 2026

View reviewed changes

Abadima and others added 6 commits January 25, 2026 23:46

Fix Typo

ee85502

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Allow "level 0"

8e49516

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/setXP.js

1efe2c3

Allow xp = 0 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix typo

0a00975

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/leaderboard.js

55587e8

Remove unnecessary const Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

b87ea80

Copilot AI mentioned this pull request Jan 26, 2026

Fix levelUp event emission logic in addLevel #11

Merged

1 task

Copilot AI and others added 3 commits January 26, 2026 04:55

Fix levelUp event comparison to compare previous level with new level

b39a703

Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>

Merge pull request #11 from Abadima/copilot/sub-pr-10

13ac2d9

Fix levelUp event emission logic in addLevel

Initial plan

e9b44c8

Copilot AI mentioned this pull request Jan 26, 2026

Fix race condition in setXP causing stale document overwrites #12

Merged

1 task

Initial plan

8f3374f

Abadima and others added 3 commits January 26, 2026 00:07

Merge pull request #13 from Abadima/copilot/sub-pr-10-another-one

005ed73

Fix setLevel to capture previous level before update

Merge pull request #14 from Abadima/copilot/sub-pr-10-yet-again

145cbee

Fix type coercion in setLevel to prevent incorrect event emission

small patches

ec35b9f

Abadima requested a review from Copilot January 26, 2026 05:19

Copilot started reviewing on behalf of Abadima January 26, 2026 05:19 View session

Copilot AI reviewed Jan 26, 2026

View reviewed changes

Initial plan

0371ece

Copilot AI mentioned this pull request Jan 26, 2026

Fix level emission, negative number handling, and member validation issues #15

Merged

6 tasks

Copilot AI and others added 3 commits January 26, 2026 05:27

Apply review feedback: fix level params, negative numbers, indentatio…

eaefb2b

…n, member checks, and logging Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>

Revert connect.js to only notify when explicitly set to true

c6d1dc7

Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>

Merge pull request #15 from Abadima/copilot/sub-pr-10-one-more-time

d7d173a

Fix level emission, negative number handling, and member validation issues

Copilot AI mentioned this pull request Jan 26, 2026

Verify and confirm review feedback implementation #16

Closed

1 task

Abadima requested a review from Copilot January 26, 2026 05:41

Copilot started reviewing on behalf of Abadima January 26, 2026 05:41 View session

Copilot AI reviewed Jan 26, 2026

View reviewed changes

Comment thread src/addXP.js Outdated

Comment thread src/leaderboard.js Outdated

Comment thread src/connect.js

Comment thread src/rank.js

Comment thread eslint.config.cjs Outdated

Comment thread src/addLevel.js Outdated

Initial plan

c1f15b9

Copilot AI mentioned this pull request Jan 26, 2026

[WIP] Merge LTS to latest code version #17

Merged

9 tasks

Copilot AI and others added 4 commits January 26, 2026 05:51

Apply review feedback: fix validation, performance, and config issues

be32272

Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>

Update error message in addLevel to match validation logic

051f656

Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>

Improve consistency and performance in validation and deletion

a82c91f

Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>

Merge pull request #17 from Abadima/copilot/sub-pr-10-please-work

afbb671

[WIP] Merge LTS to latest code version

Abadima merged commit 6d2e9a3 into latest Jan 26, 2026
1 check failed

Uh oh!

Conversation

Abadima commented Jan 26, 2026

Uh oh!

codacy-production Bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codacy's Analysis Summary

Uh oh!

Abadima commented Jan 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 26, 2026

Uh oh!

Copilot AI commented Jan 26, 2026

Uh oh!

codacy-production Bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codacy's Analysis Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Abadima commented Jan 26, 2026

Uh oh!

Copilot AI commented Jan 26, 2026

Uh oh!

Abadima commented Jan 26, 2026

Uh oh!

Copilot AI commented Jan 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Abadima commented Jan 26, 2026

Uh oh!

Copilot AI commented Jan 26, 2026

Uh oh!

codacy-production Bot commented Jan 26, 2026

Codacy's Analysis Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codacy-production Bot commented Jan 26, 2026 •

edited

Loading

codacy-production Bot commented Jan 26, 2026 •

edited

Loading