Skip to content

Fix level emission, negative number handling, and member validation issues#15

Merged
Abadima merged 3 commits into
LTSfrom
copilot/sub-pr-10-one-more-time
Jan 26, 2026
Merged

Fix level emission, negative number handling, and member validation issues#15
Abadima merged 3 commits into
LTSfrom
copilot/sub-pr-10-one-more-time

Conversation

Copilot AI commented Jan 26, 2026

Copy link
Copy Markdown
Contributor
  • Fix addLevel.js to pass user.level to notifyLevelUp instead of input level
  • Remove redundant number coercion in setLevel.js
  • Handle negative numbers in shortener.js to prevent NaN
  • Fix indentation in levelUpNotifier.js (spaces to tabs)
  • Add member existence check in rank.js before using member properties
  • Revert connect.js to only notify when user explicitly sets notify: true

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@codacy-production

codacy-production Bot commented Jan 26, 2026

Copy link
Copy Markdown

Codacy's Analysis Summary

5 new issues (≤ 0 medium issue)
1 new security issue (≤ 0 issue)
0 complexity
2 duplications

Review Pull Request in Codacy →

AI Reviewer available: add the codacy-review label to get contextual insights without leaving GitHub.

…n, member checks, and logging

Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>
Copilot AI changed the title [WIP] Merge LTS to latest codebase with refactoring Fix level emission, negative number handling, and member validation issues Jan 26, 2026
Copilot AI requested a review from Abadima January 26, 2026 05:29
@Abadima

Abadima commented Jan 26, 2026

Copy link
Copy Markdown
Owner

@copilot I want connect.js to NOT notify unless user says true, please undo that specific change.

Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>

Copilot AI commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

@copilot I want connect.js to NOT notify unless user says true, please undo that specific change.

Reverted in commit c6d1dc7. The connect.js now only logs when notify: true is explicitly set, while keeping the options = {} default instead of options = [].

@Abadima
Abadima marked this pull request as ready for review January 26, 2026 05:36
@Abadima
Abadima merged commit d7d173a into LTS Jan 26, 2026
1 check failed
Copilot stopped work on behalf of Abadima due to an error January 26, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants