Fix race condition in setXP causing stale document overwrites

[Copilot]

Information

findOneAndUpdate returns the pre-update document by default. Mutating and calling save() on this stale document overwrites the XP value just set in the database.

Changes:

• Calculate level before database operation
• Update xp and level atomically in single findOneAndUpdate call
• Return both xp and level (consistent with setLevel, addXP)

Before:

const user = await levels.findOneAndUpdate(
  { user: userID, guild: guildID },
  { xp: xp },  // Update xp
  { upsert: true }
);  // Returns pre-update document

const lvl = Math.floor(0.1 * Math.sqrt(xp));
if (user.level !== lvl) {
  user.level = lvl;
  await user.save();  // Overwrites xp with stale value
}

After:

const lvl = Math.floor(0.1 * Math.sqrt(xp));

await levels.findOneAndUpdate(
  { user: userID, guild: guildID },
  { xp: xp, level: lvl },  // Atomic update
  { upsert: true }
);

return { xp, level: lvl };

Issue Related

Addresses feedback from PR #10: #10 (comment)

Checks

• Does the package work as intended?

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[codacy-production]

Codacy's Analysis Summary

2 new issues (≤ 0 medium issue)
0 new security issue (≤ 0 issue)
0 complexity
0 duplications

Review Pull Request in Codacy →

✨ AI Reviewer available: add the codacy-review label to get contextual insights without leaving GitHub.