Fix levelUp event emission logic in addLevel#11
Merged
Conversation
Merged
Codacy's Analysis Summary0 new issue (≤ 0 medium issue) Review Pull Request in Codacy →
|
Co-authored-by: Abadima <39747270+Abadima@users.noreply.github.com>
Abadima
marked this pull request as ready for review
January 26, 2026 04:56
Copilot
AI
changed the title
[WIP] Address feedback on 'Merge LTS to Latest' pull request
Fix levelUp event emission logic in addLevel
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
The
levelUpevent decision compared the previous level to the increment amount instead of the new level, causing incorrect event emission.Changed line 46 in
src/addLevel.js:This ensures
levelUptriggers only when the user's level actually changes.Issue Related
Addresses feedback from PR #10 review comment
Checks
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.