Repository navigation
Pull request: Match GitHub's reaction picker, merge box and merge button states - #73
Merged
Merged
Conversation
whereareiam
force-pushed
the
fix/pull-sidebar-hover
branch
from
October 4, 2026 07:49
3d18ead to
e9d04f2
Compare
whereareiam
changed the title
…ton states Measured against GitHub signed in: - The reaction picker is two rows of four 32px buttons instead of an uneven three-column grid. - A mergeable pull request gets the green box border back, a blocked one a red border, and section dividers use the muted border colour. - While the merge form is open it replaces the other sections, in a neutral box with monospace fields. - Sidebar headings turn blue on hover without an underline. Forgejo marks the collapsed merge button red whenever checks are unmet, even when the action only schedules the merge for when checks succeed. The button now follows the action: primary for a scheduled merge, danger only for an override. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
whereareiam
force-pushed
the
fix/pull-sidebar-hover
branch
from
October 4, 2026 07:56
695fe3d to
bc589db
Compare
whereareiam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Measured against GitHub in a signed-in browser (pull request page, dark theme).
rgb(35,134,54)rgb(35,134,54)Merge button states
Forgejo sets the collapsed button group to
redwhenever checks are unmet, even when the selected action only schedules the merge ("when checks succeed"), while its own confirm button for that action isprimary. The theme script now marks a scheduled merge (label differs from the plain merge action, so it works in any language) and the button is shown primary; danger remains for an override only.A blocked pull request's box border now follows its red status badge (not measured on GitHub; no blocked pull request was available there).
Not changed, because Forgejo has no equivalent: GitHub's "Commit message" / "Extended description" field labels (would be hard-coded English) and the per-method descriptions in the merge method menu.
Verification
Checked in the preview on a mergeable pull request (picker open, merge form open and cancelled, heading hover).
bun vitest(403 passed),bun checkand Prettier pass. Screenshots are not attached.🤖 Generated with Claude Code