Repository navigation
Pull request: Make the Update branch menu a single-choice menu - #84
Merged
Merged
Conversation
The menu overlapped its button by 5px, was narrower than the button group, drew a divider under the first row and marked the current choice with a filled row. It now opens 4px below the button at the group's width, rows have no dividers, and the current choice carries a check mark, as in GitHub's single-choice menus. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #83 (base is its branch): both add rules to
styles/pages/pull-request.css.What was wrong
The menu under "Update branch by merge":
The check is drawn with a mask in the text colour, so it follows light and dark themes.
Not measured against GitHub: its "Update branch" control only appears with branch protection, which is not available on a private repository without a paid plan. The pattern follows GitHub's single-choice menus (the merge method menu measured in #73 uses the same check mark).
One thing left: the first row still shows a faint highlight when the menu opens, which is Forgejo's keyboard-selection state.
Verification
Opened the menu with a real click in the preview and measured it.
bun vitest(403 passed) and Prettier pass. Screenshots are not attached.🤖 Generated with Claude Code