Repository navigation
Pull request: Restyle the review panel and diff comment forms, keep primary buttons green on focus - #75
Merged
Conversation
…rimary buttons green on focus The "Finish review" panel, the comment form opened on a diff line and the reply form under a conversation used Forgejo's stock editor. The conversation editor's rules move into a shared fragment and apply to all of them; the panel becomes GitHub's 640px dialog with a title row, the editor box and a footer. Forgejo paints a focused primary button with its blue accent, so every green button turned blue after a click once the pointer left it. Focused primary buttons now keep the primary colours. The button row under a diff conversation is aligned at 32px with a plain reply icon, and the pending comment count uses GitHub's counter inside a primary button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #73 (base is its branch); GitHub retargets this to
devwhen #73 merges.What was wrong
.ui.primary.button:focususes--color-primary-hover, which is the blue accent in this theme. After a click, any primary button stayed blue until it lost focus (visible on "Finish review" while its panel is open).What changed
styles/components/issues/editor.ts(new): the conversation editor's rules as two shared fragments,markdownEditorandattachmentDropzone.issue_conversation.tsnow uses them instead of its own copy.styles/components/issues/pull_files_review.ts(new): the review panel, the diff comment form, the conversation button row and the counter.styles/public/button.ts: focused primary buttons keep the primary colours.Measured against GitHub's "Finish your review" dialog (signed in):
rgb(34,126,247)rgb(35,134,54)Kept as Forgejo has it: three submit buttons (Approve / Comment / Request changes) instead of GitHub's radio group with one submit button.
Verification
In the preview on a pull request's Files changed tab: opened the panel (Write and Preview), commented on a line, added a single comment, started a review with a pending comment, replied in a conversation, submitted an approval, and checked the result on the Conversation tab.
bun vitest(403 passed),bun checkand Prettier pass. Screenshots are not attached.🤖 Generated with Claude Code