feat(experimental): add table-backed GPU k-means and IVF-flat - #2949
Merged
ibgreen-openai merged 1 commit intoAug 7, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4d74873a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibgreen-openai
force-pushed
the
codex/luvs-arrow-embeddings
branch
from
August 5, 2026 01:50
0441c32 to
d0dc80f
Compare
ibgreen-openai
force-pushed
the
codex/luvs-kmeans-ivf
branch
2 times, most recently
from
August 5, 2026 02:06
d57d449 to
0dafc94
Compare
ibgreen-openai
force-pushed
the
codex/luvs-arrow-embeddings
branch
from
August 6, 2026 21:46
329955a to
113a79f
Compare
ibgreen-openai
changed the base branch from
codex/luvs-arrow-embeddings
to
codex/luvs-foundation
August 6, 2026 21:46
ibgreen-openai
force-pushed
the
codex/luvs-kmeans-ivf
branch
2 times, most recently
from
August 6, 2026 22:09
47134cd to
6013af0
Compare
ibgreen-openai
force-pushed
the
codex/luvs-foundation
branch
from
August 6, 2026 22:09
e7dfcdf to
f9eb796
Compare
ibgreen-openai
force-pushed
the
codex/luvs-kmeans-ivf
branch
from
August 6, 2026 22:16
6013af0 to
7c21fc6
Compare
ibgreen-openai
force-pushed
the
codex/luvs-foundation
branch
from
August 6, 2026 22:16
f9eb796 to
135f47a
Compare
ibgreen-openai
force-pushed
the
codex/luvs-kmeans-ivf
branch
from
August 6, 2026 22:24
7c21fc6 to
b64cc11
Compare
ibgreen-openai
force-pushed
the
codex/luvs-foundation
branch
from
August 6, 2026 22:24
135f47a to
4fa67be
Compare
ibgreen-openai
force-pushed
the
codex/luvs-kmeans-ivf
branch
from
August 7, 2026 00:29
b64cc11 to
ced560b
Compare
ibgreen-openai
force-pushed
the
codex/luvs-foundation
branch
2 times, most recently
from
August 7, 2026 00:34
3bdc79b to
9df7ffd
Compare
ibgreen-openai
force-pushed
the
codex/luvs-kmeans-ivf
branch
from
August 7, 2026 00:34
ced560b to
f084cfe
Compare
Base automatically changed from
codex/luvs-foundation
to
codex/luvs-command-graph-aliasing
August 7, 2026 00:35
ibgreen-openai
force-pushed
the
codex/luvs-kmeans-ivf
branch
2 times, most recently
from
August 7, 2026 00:48
34734c0 to
7a41644
Compare
ibgreen-openai
force-pushed
the
codex/luvs-kmeans-ivf
branch
from
August 7, 2026 00:52
7a41644 to
91c460e
Compare
ibgreen-openai
merged commit Aug 7, 2026
957b7c4
into
codex/luvs-command-graph-aliasing
6 checks passed
ibgreen-openai
added a commit
that referenced
this pull request
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Add deterministic WebGPU k-means clustering and genuinely indexed IVF-flat approximate similarity search over borrowed, chunk-preserving fixed-size-list GPU table columns. Explain the abstractions, their purpose, ownership boundaries, and accuracy/performance tradeoffs directly in this PR.
Changes
GPUTable/GPUVectorembedding storage.Verification
nvm use(Node 22.22.1).yarn install: the configured package registry returns HTTP 403 for required tarballs; verification reuses the existing isolated dependency tree and CI performs the normal immutable install.yarn lint fix.yarn buildafter the final implementation and formatting changes.yarn website:build.(cd website && yarn build).Risks
Reduced IVF probing is approximate by design; each persistent packed index array must fit one storage binding and oversized indexes fail before graph mutation. An unrelated existing Billion-Point Spatial Atlas visual smoke intermittently loses its SwiftShader device on both this branch and
master; its failure happens before luVS coverage starts and is being investigated separately.