fix(experimental): canonicalize typed and dynamic graph buffer imports - #2943
Open
ibgreen-openai wants to merge 1 commit into
Open
fix(experimental): canonicalize typed and dynamic graph buffer imports#2943ibgreen-openai wants to merge 1 commit into
ibgreen-openai wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33e233fa1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibgreen-openai
force-pushed
the
codex/luvs-command-graph-aliasing
branch
2 times, most recently
from
August 6, 2026 21:45
d2bb5d2 to
586682e
Compare
ibgreen-openai
changed the base branch from
master
to
codex/luvs-spdx-prerequisite
August 6, 2026 21:45
ibgreen-openai
force-pushed
the
codex/luvs-command-graph-aliasing
branch
2 times, most recently
from
August 7, 2026 11:03
38dfc85 to
d6b2c87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Preserve one canonical command-graph handle when the same caller-owned GPU allocation is imported through raw buffers, typed GPU table data, or resizable
DynamicBufferwrappers.Changes
GPUDataimports instead of creating independent logical resources for the same allocation.DynamicBufferwrapper identity across backing-buffer replacement while retaining the original raw-buffer canonical handle.master's native-GPU-buffer physical alias detection, safe read-only sharing, and writable-alias rejection.Verification
yarn buildpasses.Landing order
This is the first, two-file prerequisite. Merge it directly into
masterbefore reviewing or merging the fixed-size-list table PR.