Skip to content

fix(experimental): canonicalize typed and dynamic graph buffer imports - #2943

Open
ibgreen-openai wants to merge 1 commit into
masterfrom
codex/luvs-command-graph-aliasing
Open

fix(experimental): canonicalize typed and dynamic graph buffer imports#2943
ibgreen-openai wants to merge 1 commit into
masterfrom
codex/luvs-command-graph-aliasing

Conversation

@ibgreen-openai

@ibgreen-openai ibgreen-openai commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Goals

Preserve one canonical command-graph handle when the same caller-owned GPU allocation is imported through raw buffers, typed GPU table data, or resizable DynamicBuffer wrappers.

Changes

  • Reuse an existing raw-buffer handle for later GPUData imports instead of creating independent logical resources for the same allocation.
  • Track DynamicBuffer wrapper identity across backing-buffer replacement while retaining the original raw-buffer canonical handle.
  • Preserve current master's native-GPU-buffer physical alias detection, safe read-only sharing, and writable-alias rejection.
  • Add focused real-WebGPU regressions for import ordering, wrapper identity, resized backings, borrowed ownership, and repeated graph encoding.

Verification

  • Full cross-package yarn build passes.
  • Focused actual Chromium/WebGPU graph, sorting, Arrow, similarity, clustering, IVF, and benchmark coverage: 88 tests passed.
  • Focused Node regressions across graph, tables, Arrow, luVS, and docs: 99 tests passed.

Landing order

This is the first, two-file prerequisite. Merge it directly into master before reviewing or merging the fixed-size-list table PR.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 33e233fa1f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modules/experimental/src/gpu-primitives/gpu-command-graph.ts Outdated
@ibgreen-openai
ibgreen-openai force-pushed the codex/luvs-command-graph-aliasing branch 2 times, most recently from d2bb5d2 to 586682e Compare August 6, 2026 21:45
@ibgreen-openai
ibgreen-openai changed the base branch from master to codex/luvs-spdx-prerequisite August 6, 2026 21:45
Base automatically changed from codex/luvs-spdx-prerequisite to master August 6, 2026 23:55
@ibgreen-openai ibgreen-openai changed the title fix(experimental): reject physically aliased command-graph buffers feat(experimental): add table-backed GPU vector similarity and clustering Aug 7, 2026
@ibgreen-openai
ibgreen-openai force-pushed the codex/luvs-command-graph-aliasing branch 2 times, most recently from 38dfc85 to d6b2c87 Compare August 7, 2026 11:03
@ibgreen-openai ibgreen-openai changed the title feat(experimental): add table-backed GPU vector similarity and clustering fix(experimental): canonicalize typed and dynamic graph buffer imports Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants