Skip to content

feat(experimental): add table-backed GPU k-means and IVF-flat - #3018

Open
ibgreen-openai wants to merge 4 commits into
codex/luvs-similarity-landingfrom
codex/luvs-clustering-landing
Open

feat(experimental): add table-backed GPU k-means and IVF-flat#3018
ibgreen-openai wants to merge 4 commits into
codex/luvs-similarity-landingfrom
codex/luvs-clustering-landing

Conversation

@ibgreen-openai

Copy link
Copy Markdown
Collaborator

Goals

Add deterministic WebGPU k-means clustering and truly index-directed IVF-flat similarity search.

Changes

  • Implement deterministic bounded Lloyd iterations without Float32 atomic additions.
  • Build caller-owned IVF centroids, list counts/offsets, stable source IDs, and separate logical row references.
  • Probe indexed lists directly, preserve source-aligned masks, support approximation/fallback controls, and exactly rerank selected vectors.
  • Include the complete 500-line conceptual luVS reference covering architecture, motivation, ownership, worked IVF arrays, accuracy/memory tradeoffs, graph reuse, and device-loss recovery.
  • Add focused Node and real-WebGPU clustering/index coverage.

Previously reviewed as #2949. Merge after exact similarity search reaches master.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1827468355

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modules/experimental/src/luvs/gpu-k-means.ts Outdated
Comment thread modules/experimental/src/luvs/gpu-clustering-utils.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants