-
-
Notifications
You must be signed in to change notification settings - Fork 5
Keyboard Typing #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
calvinbokchoy
wants to merge
394
commits into
main
Choose a base branch
from
percep/keyboard_typing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Keyboard Typing #220
Changes from all commits
Commits
Show all changes
394 commits
Select commit
Hold shift + click to select a range
8d18532
es cameras
umroverPerception 20b9eed
Improve backup state
umroverPerception 68b68b1
Merge branch 'urc-25' of github.com:umrover/mrover-ros2 into urc-25
umroverPerception 9875d2e
Update launch files
umroverPerception e4e99b4
es/auton config changes
umroverPerception eaf0e08
Add aruco code
umroverPerception 8de78f8
Roll back
umroverPerception 719a99c
Merge branch 'main' into urc-25
jbrhm 1132d13
updated from preliminary review
jbrhm 601b230
style.sh
jbrhm 0b43769
added rtcm msgs
jbrhm 0ec8d12
updating CI
jbrhm 3c9d866
builds locally
jbrhm d992a7f
added mrover group for localization gps
jbrhm 5aad48c
Merge branch 'main' into urc-25
jbrhm a5b6c7d
style ??
jbrhm f619214
removed merge conflicts from .gitignore
jbrhm 3763e7f
simulator now launches
jbrhm 86ce181
no teleop errors
jbrhm b0bad63
teleop deprecated
jbrhm 0efda22
working frontend
jbrhm 18a8bc9
navigating to a point in the sim
jbrhm ddf5280
updated coords
jbrhm 11235eb
Urc 25 teleop fix (#116)
kevinjin0420 339f74b
typo fix
SiddhantRBohra ac27300
cost map fixed by setting resolution
MyCabbages4 b586be2
uncommited xacro files
MyCabbages4 253576d
fixed auton waypoint list not being saved after refresh
thealvinjg 3e427e6
temp fix
jbrhm 0b29d39
Merge branch 'main' into nlj/arm-controller
alisonryckman c2362a2
Merging main into keyboard-detector
MyCabbages4 e334918
updated sim pathing
jbrhm 8220e06
Menu to select map
jbrhm 6b67a97
initial commit
MyCabbages4 79a9180
yaw skeleton code
MyCabbages4 2c3a223
prints the objects inside of the ytaml file
jbrhm 137b4da
Merge remote-tracking branch 'origin/main' into percep/keyboard_typing
MyCabbages4 a486d7f
loading from external yaml via yaml-cpp
jbrhm ef40db9
works in sim
jbrhm 9e28434
Fix style
nevenjohnson da35f7d
Merge branch 'main' into nlj/arm-controller
nevenjohnson 75455bb
Fix python style
nevenjohnson 69a2353
Fix mypy issues
nevenjohnson 310b378
camera in sim
jbrhm 0b5f9df
test map
jbrhm 9adb3a2
added lander into the map
jbrhm 25be3b8
style
jbrhm 9fcf5fb
better camera angle
jbrhm 5742cae
urdf/textures/marker0.png: convert to Git LFS
jbrhm 87a450d
git lfs
jbrhm 0d2a201
gitignore blend1 files
jbrhm fe880c0
Merge branch 'JRA/sim-maps' into percep/keyboard_typing
jbrhm 8e8a00a
topic names
MyCabbages4 a2b97b4
started work on keyboard typing
calvinbokchoy 7393118
last valid pos
jbrhm b35f4ac
Pose estimation code finished, untested, started work on kalman filter
calvinbokchoy 060c673
add initialization for kalmanFilter
JamesFriggens fbd825d
added fallback pos
ejhon1116 077fe8d
added fallback behavior to ik timeout
ejhon1116 1075e0c
style fix
ejhon1116 499a7d6
keyboard typing is building
calvinbokchoy 40cba25
keyboard typing is building
calvinbokchoy 44e9abf
removed accidental additions
calvinbokchoy 2a24ff1
implimented kalman filter
billbhong 83958b0
pose estimation working
calvinbokchoy 997df51
added appropriate headers
ejhon1116 87e4e3f
added action dependency:
ejhon1116 296453d
fixed this?
ejhon1116 4f2d158
merged with compile commands fix
ejhon1116 8a017d0
setup typing 'ik' action server and functionality
ejhon1116 3239eb6
initial commit
MyCabbages4 999ad42
add action
ejhon1116 7fd4f28
removed mutex
ejhon1116 5083ce3
compile flags added
MyCabbages4 3b6b97e
merge
calvinbokchoy 42b24ca
debugging
calvinbokchoy b470bbf
fix camera matrix constants
JamesFriggens 0844b78
small changes
MyCabbages4 aa0708c
changed to be based on typing origin
ejhon1116 53fd85d
ignore linting change
billbhong be3d0e3
implemented kalman filter
billbhong fdeb5a2
convert angles to be 0-360
JamesFriggens f60c125
correct sizing in blender
jbrhm 8b73da9
moved camera back to join e
jbrhm a2b0dc0
reformatted input box
jbrhm 0990dd0
remove unecessary
jbrhm 087ef5a
remove ar tag generator
jbrhm 8ea1ba6
removed IsDefined
jbrhm c94b745
decimated
jbrhm 384e738
updated the tags to have different ids on the lander
jbrhm 164e3b5
fixed subpix breaking pose estimation, added gaussian blur and equali…
calvinbokchoy 76eb7ce
added catch for valid tag offsets
billbhong e9e1701
update lander aruco tags
jbrhm 4b675ba
sim fix for the arm sagging issue
ejhon1116 454afed
style
ejhon1116 686f548
merged in keyboard branch
MyCabbages4 2531976
fixed kalman filter/tag offset
billbhong 0b9b39b
updated tag offset comments
billbhong 872a603
debugging pose estimation
calvinbokchoy f871287
merge
calvinbokchoy d349bca
updated offsets
billbhong 007be7e
readded accidentally deleted code
calvinbokchoy 6be7903
fixed some offet bugs
calvinbokchoy eac3efc
add csv logging for x,y,z,roll,pitch,yaw (intended use is to then cop…
JamesFriggens 74275d5
merge (TOOK FOREVER TO FIND MISSING CURLY BRACE)
JamesFriggens e59f9fe
merging
calvinbokchoy 0a09d93
Merge branch 'percep/keyboard_typing' of github.com:umrover/mrover-ro…
calvinbokchoy 31a0ba5
made detection better
calvinbokchoy a909827
changed tag offset method
billbhong 9513f72
merging
calvinbokchoy fcf05ae
Merge branch 'percep/keyboard_typing' of github.com:umrover/mrover-ro…
calvinbokchoy f970ba2
tuned kalman filter
billbhong f5ba33a
merging
calvinbokchoy 0956e41
Merge branch 'percep/keyboard_typing' of github.com:umrover/mrover-ro…
calvinbokchoy ef83c0e
add ik publisher and function for publishing ik message for arm control
JamesFriggens b63fed9
merge
JamesFriggens cf618e3
add toggle for pose logging (press the r key when you are on the gray…
JamesFriggens f815f92
updated camera to key transform (untested)
billbhong b128072
merged with main, sim is cooked (speciically lander)
calvinbokchoy 96f98f1
reverted to old lander mesh as new merge did not have tag offset, twe…
calvinbokchoy c4892bc
Merge branch 'percep/keyboard_typing' into kb/keyboard-typing
MyCabbages4 fe4b79c
updated to match percep
MyCabbages4 94dc918
added nav action
MyCabbages4 aae31d8
added action server/client infra
MyCabbages4 44b5877
added test action server
MyCabbages4 a1caf22
renamed server to follow icd
MyCabbages4 2f7707f
yaw callback control and some comments
MyCabbages4 80732ce
added cancel logic
MyCabbages4 7e67114
nav cancel logic
MyCabbages4 156d1d5
first commit
a3801749 8106e0f
Merge branch 'main' into percep/keyboard_typing
JamesFriggens dde518e
Add basic target position method
githubAnish 5625572
first commit
a3801749 40dfffe
some more edits
a3801749 2fe40e7
reconfigured action server
MyCabbages4 e7db74b
V2...:(
a3801749 4dd667e
add keyboard hashmap and z key transformation vector
JamesFriggens c87e4ae
started work on pose to se3
calvinbokchoy f7d915a
Merge remote-tracking branch 'origin/kb/keyboard-typing' into percep/…
calvinbokchoy 70873aa
Two carrot pose impl
githubAnish 581bb4d
fixes
calvinbokchoy cb60374
more changes
githubAnish dafc887
V3 - yet to be fixed
a3801749 ccd3f73
transforms published to tree, started work on moving the arm
calvinbokchoy 2dfd685
V3 - needs more fixing
a3801749 bd2e60d
First commit
a3801749 a9acd6e
First version
a3801749 9fbaa37
Second version
a3801749 72ddc20
second version, some variable constant changes
a3801749 17564db
third version
a3801749 b9aeec5
version with carrot movement restriction
a3801749 3bcafc0
arm alignment works, yaw publishing works
calvinbokchoy e09d079
modified transforms
billbhong 4d0c726
added camera transform to current pose, cleaned up some stuff, disabl…
calvinbokchoy e5369c9
added constants to cmake list, cleaned up stuff, started work on publ…
calvinbokchoy 2a68a5a
add z-key keyboard alignment from bottom left tag. Fix z-key transform
JamesFriggens 9bc6805
version 4 - close, but not close enough :(
a3801749 9d6a9b2
transform code for z also added, added dot to debug image for better …
calvinbokchoy a077f4d
added delta to keys in launch code
billbhong 98a0f84
z alignment working, made debug picture colored for better debugging
calvinbokchoy 636b402
version 5 - first working implementation
a3801749 acd6e54
Merge remote-tracking branch 'origin/ej/typing-ik' into percep/keyboa…
calvinbokchoy ea443eb
fixed get_bad_optional issue, fine tuned x direction drift when going…
a3801749 b30ebfc
added extern to hpp, changed transform to use arm_gripper_link
calvinbokchoy ba8a236
Merge remote-tracking branch 'origin/main' into ej/arm-fallback-fix
ejhon1116 a5a2fdd
changed ee_pos/vel to ik_pos/vel
ejhon1116 949e199
add gripper rotation function for keyboard typing
JamesFriggens 5e47610
fixed offset logic
calvinbokchoy ffd2914
limit changes and icd changes
ejhon1116 64535e6
seems to be working
ejhon1116 a1c882c
Merge remote-tracking branch 'origin/ej/new-arm-control' into percep/…
calvinbokchoy a698776
arm no longer limp, starting debugging action server
calvinbokchoy 629a629
typing sequence working
calvinbokchoy e222107
cleaned imports in pch.hpp and switched back up key from ',' to 'k' i…
JamesFriggens 69c7089
Merge branch 'percep/keyboard_typing' of github.com:umrover/mrover-ro…
JamesFriggens af9eba0
fixed gripper logic
calvinbokchoy 457b94a
transform fix
calvinbokchoy 1f8eda4
added alignment, rotation, and service call to handle_accepted
calvinbokchoy 98f1442
Co-authored-by: Calvin <eternaks@users.noreply.github.com>
JamesFriggens 8a961c1
Merge branch 'percep/keyboard_typing' of github.com:umrover/mrover-ro…
JamesFriggens 9f3d6b5
uncooked rotation
calvinbokchoy 0aa4b89
started work on aruco library
calvinbokchoy 0d805b9
ditching aruco library
calvinbokchoy 40a6a1a
implemented the markley method
calvinbokchoy a563567
started work on adding parameters for node instead of hardcoded const…
calvinbokchoy 2146373
started work on vmf
calvinbokchoy 6e58827
constants fix
calvinbokchoy 3f72a3d
complete tvec sum for vectorMedianFilter
JamesFriggens 2c19242
implimented median rvec filter
billbhong f2f1836
Merge branch 'percep/keyboard_typing' of github.com:umrover/mrover-ro…
JamesFriggens 91480ee
fixed median filter rvec
billbhong 9546bd1
Merge branch 'percep/keyboard_typing' of github.com:umrover/mrover-ro…
JamesFriggens 864c73a
complete rvec and tvec vectorMedianFilter and find min sum of the two
JamesFriggens 01ca49f
merging
calvinbokchoy 7cad497
Merge branch 'percep/keyboard_typing' of github.com:umrover/mrover-ro…
calvinbokchoy f6afeca
Merge remote-tracking branch 'origin/main' into percep/keyboard_typing
MyCabbages4 1eb347a
icd changes
ejhon1116 e9c54f4
fixed initial arm position
ejhon1116 c044fb9
merge main
JamesFriggens ff60bdd
added pusher service and wait at target:
ejhon1116 f967b9f
debug typing script added
ejhon1116 e01494a
removed unecessary includes
ejhon1116 9848346
added pusher and wait
ejhon1116 e653163
removed unecessary diffs
ejhon1116 3f433d5
removed unecessary diffs in hpp
ejhon1116 51977b0
Merge remote-tracking branch 'origin/main' into ej/typing-ik
ejhon1116 17c428d
merging testing branch
calvinbokchoy 41ed01e
Merge remote-tracking branch 'origin/main' into ej/typing-ik
ejhon1116 fa644e4
typing_ik -> typing_pos
ejhon1116 525954f
fix formatting
ejhon1116 e03207b
removed [[maybe_unused]]
ejhon1116 948a187
pub fk arm_fk links
ejhon1116 94ce6cb
working in sim
calvinbokchoy 63ae569
Merge remote-tracking branch 'origin/main' into percep/keyboard_typing
calvinbokchoy 9b95cae
percep testing 4-7-26
danielryckman c5f0505
made finger_cam accurate in sim, arm_controller fixes
calvinbokchoy 9f90363
transform fixes
calvinbokchoy c391eca
Merge remote-tracking branch 'origin/main' into calv/typing-testing
calvinbokchoy 60f3aed
Merge branch 'calv/typing-testing' into percep/keyboard_typing
calvinbokchoy 563f22e
accounted for roll in key transforms
calvinbokchoy 3533be2
Merge remote-tracking branch 'origin/main' into calv/typing-testing
calvinbokchoy c8606f0
Merge branch 'calv/typing-testing' into percep/keyboard_typing
calvinbokchoy fb8da01
Merge remote-tracking branch 'origin/main' into percep/keyboard_typing
calvinbokchoy 891d22f
First version done
a3801749 14efb0a
First push may have been bad?
a3801749 99173b5
style fixes
calvinbokchoy 80e7e3d
extensions.json fix
calvinbokchoy fa838cd
Merge remote-tracking branch 'origin/ad/arm_transform' into ej/typing-ik
ejhon1116 ec4d046
added transforms
ejhon1116 0064653
Merge remote-tracking branch 'origin/ej/typing-ik' into percep/keyboa…
calvinbokchoy 20f264d
Merge remote-tracking branch 'origin/main' into percep/keyboard_typing
calvinbokchoy f6721c5
Merge remote-tracking branch 'origin/main' into percep/keyboard_typing
calvinbokchoy feb884b
fixed cmakelist, moved typing node to jetson arm, deleted useless files,
calvinbokchoy 6afaf74
removed starter project solutions, reset simulator.hpp to main
calvinbokchoy 5319129
restored wrong simulator.hpp
calvinbokchoy f322e09
removed arm_controller changes
calvinbokchoy d19d8a1
Merge remote-tracking branch 'origin/main' into percep/keyboard_typing
calvinbokchoy 09f0f32
style fixes, cleaned up keyboard typing code
calvinbokchoy 467f88b
fixed gitignore, deleted unused typing deltas
calvinbokchoy b629e1e
removed typing delta include
calvinbokchoy acb7ce6
minor fixes
calvinbokchoy 0712b27
removed constants.hpp
calvinbokchoy 2812ca8
renamed yaw topic
calvinbokchoy 4169b71
main merge
MyCabbages4 b0b6868
Merge remote-tracking branch 'origin/main' into percep/keyboard_typing
MyCabbages4 2f025e6
updated transforms and action server
MyCabbages4 69fd17c
style fixes
MyCabbages4 c9ac5e6
removed old functions
MyCabbages4 b085b5c
merged main
MyCabbages4 c17ed66
merge main
danielryckman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
calvinbokchoy marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /**: | ||
| ros__parameters: | ||
| tag_size: 0.02 | ||
| # Format: [id, x, y, z] | ||
|
|
||
| # Distance of each tag to bottom left tag, probably wont be needed but change if necessary | ||
| # Will need to change tag id on day of comp | ||
| tag_offsets: [ | ||
| 4.0, 0.0, 0.0, 0.0, # Bottom-left | ||
| 5.0, 0.41407, 0.0, 0.0, # Bottom-right | ||
| 3.0, 0.41407, 0.183444, 0.0, # Top-left | ||
| 2.0, 0.0, 0.183444, 0.0 # Top-right | ||
| ] | ||
| min_code_length: 3 | ||
| max_code_length: 6 | ||
|
|
||
| camera_matrix: [297.5423204165929, 0.0, 306.51784066632075, | ||
| 0.0, 295.1006235094907, 247.4880266546329, | ||
| 0.0, 0.0, 1.0] | ||
|
|
||
| # camera_matrix: [294.8447664894051, 0.0, 320.781111263661, | ||
| # 0.0, 292.9945007031336, 241.50291271027783, | ||
| # 0.0, 0.0, 1.0] | ||
|
|
||
| distortion_coefficients: [-0.002013779189917317, | ||
| -0.05320314517636387, | ||
| -0.0013949346108894896, | ||
| 0.00023247660995265573, | ||
| 0.018284177139663432] | ||
|
|
||
| # Add vertical and horizontal dist from tag center to keyboard as needed | ||
| # vertical z key from keyboard corner = 0.031575 | ||
| # horizontal z key from keyboard corner 0.05495 | ||
| z_key_transform: [0.041575, 0.06495, 0.0303784] | ||
|
|
||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| from pathlib import Path | ||
|
|
||
| from ament_index_python import get_package_share_directory | ||
|
|
||
| import launch | ||
| from launch_ros.actions import Node, LoadComposableNodes | ||
| from launch_ros.descriptions import ComposableNode | ||
|
|
||
|
|
||
| def generate_launch_description(): | ||
| # keyboard typing node | ||
| keyboard_typing = Node( | ||
| package="mrover", | ||
| executable="keyboard_typing", | ||
| name="keyboard_typing", | ||
| parameters=[Path(get_package_share_directory("mrover"), "config", "keyboard_typing.yaml")], | ||
| respawn=False, | ||
| ) | ||
|
|
||
| # gripper: [0.16533, 0, 0.059547] # forward, horizontal, vertical | ||
| # gripper_pitch: 1.134 | ||
|
|
||
| # base_link_to_zed = Node( | ||
| # package="tf2_ros", | ||
| # executable="static_transform_publisher", | ||
| # arguments=["0", "0", "1", "0", "0", "0", "1", "base_link", "zed_left_camera_frame"], | ||
| # ) | ||
|
|
||
| # joint DE to camera: [0, 0.03713988, 0.0945642] roll: 0, pitch: 1.134, yaw: 0 | ||
| arm_e_link_to_cam = Node( | ||
| package="tf2_ros", | ||
| executable="static_transform_publisher", | ||
| arguments=["0.02948991", "0", "-0.0456159", "0", "-1.0996", "0", "arm_fk_de", "finger_camera_frame"], | ||
| ) | ||
|
|
||
| return launch.LaunchDescription([keyboard_typing, arm_e_link_to_cam]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #include <keyboard_typing/keyboard_typing.hpp> | ||
|
|
||
| auto main(int argc, char** argv) -> int { | ||
| rclcpp::init(argc, argv); | ||
| auto keyboardT = std::make_shared<mrover::KeyboardTypingNode>(); | ||
| rclcpp::executors::SingleThreadedExecutor executor; | ||
| executor.add_node(keyboardT); | ||
| executor.spin(); | ||
|
|
||
| rclcpp::shutdown(); | ||
| return EXIT_SUCCESS; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.