Import basic.css in agogo, epub, nonav, scrolls, and traditional themes - #14635
Open
joyboy-type wants to merge 1 commit into
Open
Import basic.css in agogo, epub, nonav, scrolls, and traditional themes#14635joyboy-type wants to merge 1 commit into
joyboy-type wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9093
Summary
The
agogo,epub,nonav,scrolls, andtraditionalthemesinherit from
basicbut their stylesheets did not importbasic.css.This adds the missing import so foundational styles changed in
basicpropagate automatically to these themes.
Changes
@import url("basic.css");to the stylesheets of the five themes.CHANGES.rstentry.Testing
pytest tests/test_theming/test_theming.py— 28 passedpytest tests/test_builders/test_build_epub.py— 15 passed, 1 skipped (epubcheck)