Import basic.css in agogo, epub, nonav, scrolls, and traditional themes

CHANGES.rst

@@ -1,6 +1,13 @@
 Release 9.1.1 (in development)
 ==============================
 
+Features added
+--------------
+
+* #9093: Import ``basic.css`` in the ``agogo``, ``epub``, ``nonav``,
+  ``scrolls``, and ``traditional`` themes.
+  Patch by joyboy
+
 Bugs fixed
 ----------
 

sphinx/themes/agogo/static/agogo.css.jinja

@@ -2,6 +2,8 @@
  * Sphinx stylesheet -- agogo theme.
  */
 
+@import url("basic.css");
+
 * {
   margin: 0px;
   padding: 0px;

sphinx/themes/epub/static/epub.css.jinja

@@ -2,6 +2,8 @@
  * Sphinx stylesheet -- epub theme.
  */
 
+@import url("basic.css");
+
 /* -- main layout ----------------------------------------------------------- */
 
 {% if theme_writing_mode is defined %}

sphinx/themes/nonav/static/nonav.css.jinja

@@ -2,6 +2,8 @@
  * Sphinx stylesheet -- nonav theme.
  */
 
+@import url("basic.css");
+
 /* -- main layout ----------------------------------------------------------- */
 
 div.clearer {

sphinx/themes/scrolls/static/scrolls.css.jinja

@@ -2,6 +2,8 @@
  * Sphinx stylesheet -- scrolls theme.
  */
 
+@import url("basic.css");
+
 body {
     background-color: #222;
     margin: 0;

sphinx/themes/traditional/static/traditional.css.jinja

@@ -2,6 +2,8 @@
  * Sphinx stylesheet -- traditional docs.python.org theme.
  */
 
+@import url("basic.css");
+
 body {
     color: #000;
     margin: 0;

tests/test_theming/test_theming.py

@@ -240,6 +240,34 @@ def test_theme_builds(
             pytest.fail(f'Failed to parse {html_file.relative_to(app.outdir)}: {exc}')
 
 
+@pytest.mark.parametrize(
+    ('theme_name', 'css_name'),
+    [
+        ('agogo', 'agogo.css'),
+        ('epub', 'epub.css'),
+        ('nonav', 'nonav.css'),
+        ('scrolls', 'scrolls.css'),
+        ('traditional', 'traditional.css'),
+    ],
+)
+def test_bundled_themes_import_basic_css(
+    make_app: Callable[..., SphinxTestApp],
+    rootdir: Path,
+    sphinx_test_tempdir: Path,
+    theme_name: str,
+    css_name: str,
+) -> None:
+    """Bundled themes that inherit ``basic`` should import ``basic.css``."""
+    testroot_path = rootdir / 'test-basic'
+    srcdir = sphinx_test_tempdir / f'test-theme-{theme_name}-css'
+    shutil.copytree(testroot_path, srcdir)
+
+    app = make_app(srcdir=srcdir, confoverrides={'html_theme': theme_name})
+    app.build()
+    css = (app.outdir / '_static' / css_name).read_text(encoding='utf8')
+    assert '@import url("basic.css");' in css
+
+
 def test_config_file_toml() -> None:
     config_path = HERE / 'theme.toml'
     cfg = _load_theme_toml(config_path)