Skip to content

Import basic.css in agogo, epub, nonav, scrolls, and traditional themes - #14634

Closed
joyboy798 wants to merge 1 commit into
sphinx-doc:masterfrom
joyboy798:fix/9093-import-basic-css
Closed

Import basic.css in agogo, epub, nonav, scrolls, and traditional themes#14634
joyboy798 wants to merge 1 commit into
sphinx-doc:masterfrom
joyboy798:fix/9093-import-basic-css

Conversation

@joyboy798

Copy link
Copy Markdown

Fixes #9093

Summary

The agogo, epub, nonav, scrolls, and traditional themes
inherit from basic but their stylesheets did not import basic.css.
This adds the missing import so foundational styles changed in basic
propagate automatically to these themes.

Changes

  • Add @import url("basic.css"); to the stylesheets of the five themes.
  • Add a regression test verifying the import is present in the rendered CSS.
  • Add a CHANGES.rst entry.

Testing

  • pytest tests/test_theming/test_theming.py — 28 passed
  • pytest tests/test_builders/test_build_epub.py — 15 passed, 1 skipped (epubcheck)

@joyboy798

Copy link
Copy Markdown
Author

The CI failures appear unrelated to this change — they happen during the checkout step (failed to encode 'tests/roots/test-warnings/wrongenc.inc' from UTF-8 to iso-8859), before any tests run. The wrongenc.inc files are unchanged in this PR (identical blob to master), and the same test-matrix jobs are failing on other open PRs (e.g. #14621).

@joyboy798

Copy link
Copy Markdown
Author

Superseded by #14635 — moved to the joyboy-type account. Closing this one.

@joyboy798 joyboy798 closed this Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some themes do not import CSS from basic

1 participant