utilities: support cisco ASIC name - #4717
Open
anamehra wants to merge 2 commits into
Open
Conversation
Signed-off-by: Anand Mehra (anamehra) <anamehra@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Signed-off-by: Anand Mehra (anamehra) <anamehra@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
anamehra
marked this pull request as ready for review
July 27, 2026 00:15
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Support the shorter
ciscoASIC name in Cisco-specific utilities paths that already handlecisco-8000.Related: sonic-net/sonic-buildimage#27281
How I did it
cisco-8000andcisco.asic_type: cisco.How to verify it
git diff --checkpython3 -c "import json; json.load(open('generic_config_updater/gcu_field_operation_validators.conf.json')); print('json ok')"env PYTHONPYCACHEPREFIX=/private/tmp/pycache-sonic-utilities python3 -m py_compile config/main.py generic_config_updater/field_operation_validators.py show/plugins/cisco-8000.py sonic_installer/bootloader/grub.py tests/generic_config_updater/field_operation_validator_test.pybash -n scripts/fast-reboot scripts/generate_dumpPrevious command output (if the output of a command-line utility has changed)
N/A
New command output (if the output of a command-line utility has changed)
N/A