[orchagent]: support cisco platform name - #4793
Open
anamehra wants to merge 1 commit into
Open
Conversation
Signed-off-by: Anand Mehra (anamehra) <anamehra@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
anamehra
marked this pull request as ready for review
July 27, 2026 00:15
anamehra
requested review from
bingwang-ms,
kperumalbfn and
prsunny
as code owners
July 27, 2026 00:15
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
kperumalbfn
reviewed
Jul 28, 2026
| #define VS_PLATFORM_SUBSTRING "vs" | ||
| #define NPS_PLATFORM_SUBSTRING "nephos" | ||
| #define CISCO_8000_PLATFORM_SUBSTRING "cisco-8000" | ||
| #define CISCO_PLATFORM_SUBSTRING "cisco" |
Contributor
There was a problem hiding this comment.
@anamehra Are you changing this platform substring in all Sonic submodules?
Author
There was a problem hiding this comment.
Hi @kperumalbfn , yes, I have two additional PRs:
sonic-net/sonic-sairedis#2006
sonic-net/sonic-utilities#4717
I will open one for sonic-mgmt as well. This is not replacement but additional of Cisco substring "cisco". We will keep cisco-8000 for backward compatibility for now.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Support the shorter
ciscoplatform name in the existing Cisco-8000 orchagent handling paths.Related: sonic-net/sonic-buildimage#27281
Why I did it
The buildimage platform change uses the shorter
ciscoASIC/platform name, while SWSS should continue to use the existing Cisco-8000 behavior and PFC watchdog Lua plugins for that platform family.How I verified it
git diff --checkorchagent/pfc_detect_cisco-8000.luaandorchagent/pfc_restore_cisco-8000.luaciscoto the existing Cisco-8000 PFC watchdog plugin nameDetails if related
The new helper treats
ciscoandcisco-8000as Cisco platforms, and maps PFC watchdog plugin lookup for both names to the existing Cisco-8000 Lua files.