Repository navigation
Conversation
This was referenced Aug 31, 2026
Centralize record validation and check owner string termination. Cover both ELF classes, byte orders, section and segment access, and data mutation. Keep test registration compatible with the hash lookup changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix note indexing and record validation in the section and segment accessors. The index check used the section's byte size instead of the number of parsed notes.
Changes
memcpy, byte-order conversion, and widened padding calculations to validate the complete record.The public API is unchanged.
Tests
Eight scenarios run across ELF32/ELF64 and both byte orders. Coverage includes invalid indices, truncated and oversized records, owner names, data mutation, serialized sections/segments, and unaligned headers.
Prepared with AI assistance.