fix(exclusions): fail safe when JustWatch or Trakt are unavailable - #283
Open
rfsbraz wants to merge 2 commits into
Open
fix(exclusions): fail safe when JustWatch or Trakt are unavailable#283rfsbraz wants to merge 2 commits into
rfsbraz wants to merge 2 commits into
Conversation
Contributor
|
🐳 To test this PR, build and run directly from the branch: Using docker compose: services:
deleterr:
build: https://github.com/rfsbraz/deleterr.git#refs/pull/283/head
volumes:
- ./config:/config
environment:
LOG_LEVEL: DEBUGUsing docker build: docker build https://github.com/rfsbraz/deleterr.git#refs/pull/283/head -t deleterr:pr-283
docker run --rm -v ./config:/config -e LOG_LEVEL=DEBUG deleterr:pr-283 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



available_onexclusions silently stopped firing during outages and items the user wanted protected proceeded toward deletion._searchnow raisesJustWatchErrorso callers can tell a service failure apart from a genuine not-found, andcheck_excluded_justwatchfails safe by skipping the item for that run with a warning._fetch_list_itemsnow raisesTraktError, and the per-library processing in deleterr catches it, logs prominently, and skips the library entirely (no deletions) for that run.