Skip to content

Unhandled service errors mid-run crash the process, skipping summary and notifications #289

Description

@rfsbraz

Description

The per-library error guards in process_radarr/process_sonarr (app/deleterr.py) only catch ConfigurationError (and TraktError once #283 lands). Any other exception - radarr.get_movies() 500, sonarr.get_series() timeout, get_disk_space() failure, Tautulli pagination errors (app/modules/tautulli.py has no try/except around get_history) - propagates out of the loop and kills the whole run.

When that happens, _log_run_summary and _send_notification never execute: no summary, no failure notification, and in single-run mode the process just dies. Libraries ordered after the failing one are never processed.

Proposed Fix

  • Broaden the per-library guard to catch service-level errors (requests/pyarr exceptions), mark the library failed, and continue with the next one
  • Wrap Tautulli history pagination so a mid-pagination failure is a per-library failure, not a process crash (careful: combined with Empty or degraded Tautulli watch history can mass-delete watched content #287, a partial history must fail SAFE, not be treated as complete)
  • Always run summary + notification, even when libraries fail - a failure notification is worth more than a missing one

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions