Skip to content

fix(exclusions): fail safe when Mdblist is unavailable - #297

Open
rfsbraz wants to merge 3 commits into
mainfrom
fix/mdblist-fail-safe
Open

fix(exclusions): fail safe when Mdblist is unavailable#297
rfsbraz wants to merge 3 commits into
mainfrom
fix/mdblist-fail-safe

Conversation

@rfsbraz

@rfsbraz rfsbraz commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Fixes #288

Stacked on #283 - merge that first; this PR extends its _handle_library_failure machinery.

  • Mdblist fetch failures (network error, rate limit, HTTP 5xx) previously logged one line and returned a partial or empty list, which the caller treated as the complete exclusion set - items on the user's protection list became deletable during an mdblist outage
  • _fetch_list_items now raises a typed MdblistError instead of returning partial results; a misparsed list URL (config mistake) also raises instead of silently disabling the exclusion
  • The per-library guard catches it and skips the library for the run (fail safe), matching the Trakt behavior from fix(exclusions): fail safe when JustWatch or Trakt are unavailable #283
  • Existing tests that pinned the fail-open behavior flipped to assert the fail-safe contract; added a deleterr-level test that an mdblist failure skips the library with zero deletions

@sonarqubecloud

sonarqubecloud Bot commented Jul 5, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mdblist exclusions fail open: API errors silently disable protection

1 participant