Skip to content

[Automation] - Fix imported generic cluster e2e failures - #18713

Draft
izaac wants to merge 1 commit into
rancher:masterfrom
izaac:issue-2488
Draft

[Automation] - Fix imported generic cluster e2e failures#18713
izaac wants to merge 1 commit into
rancher:masterfrom
izaac:issue-2488

Conversation

@izaac

@izaac izaac commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes rancher/qa-tasks#2488
Fixes rancher/qa-tasks#2462
Fixes rancher/qa-tasks#2463

Occurred changes and/or fixed issues

Technical notes summary

  • #registration is not written by the router, it is a side effect of Tabbed picking a default tab, which happens once while no tab is active. The registration tab only exists after the registration token resolves, so if the token is slow another tab wins and the fragment never appears. A longer timeout cannot fix that ordering
  • Cypress timeouts are per command, so a timeout given to rowWithName() did not carry over to column(), which fell back to the 10s default. Threaded the options through
  • .should() reads its second argument as the assertion message, so timeouts passed there were ignored
  • The waiting state assertion now runs before the registration manifest is applied, where no agent can have connected yet. After the apply it is a race
  • The import button is now found by its own test id. It was found by position, which resolves to the create button whenever the import button is hidden
  • The table of contents test now asserts against the element the dashboard actually scrolls, window.scrollY is always zero here

Testing done

The failures also needed an infrastructure fix, the imported cluster's k3s was advertising its public IP so CoreDNS could never reach the API server and the cluster never went active. That is rancher/qa-infra-automation#159.

With that in place this block goes from 3 failures to a full pass, in under a minute. Validated on release-2.14 and release-2.15, master is the same change and is in draft until it has had a run of its own.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

The tests in the Imported block were failing before they reached anything they were meant to cover. Absorb the cold start of the dynamically imported list component in a before hook, select the registration tab explicitly rather than waiting for the `#registration` fragment that Tabbed only writes as a side effect of picking a default tab, assert the intermediate waiting state before the registration manifest is applied rather than after, move timeouts off `should()` where they were read as the assertion message and onto the commands that yield the element, thread them through `ListRowPo.column` so they survive narrowing a row to a cell, target the import button by its own test id rather than by position in the masthead, navigate to the detail page instead of gating on the create form redirect which is unreliable after an import (see rancher#18712), and assert the table of contents scroll against the inner container the dashboard actually scrolls rather than the window.
@izaac izaac added this to the v2.16.0 milestone Aug 7, 2026
@izaac izaac added QA/None QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🔄 Auto-Retry Failed Run

The Tests workflow failed for the commits below and has been automatically retried.
Follow up on a retried run through its link if needed.

Commit Workflow run Retried at
50bc547 31135591678 2026-08-07 01:16 UTC
2049d4b 31135196814 2026-08-07 01:25 UTC
d0f8985 31135826002 2026-08-07 01:30 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None

Projects

None yet

1 participant