[backport v2.15.1] [Automation] - Fix imported generic cluster e2e failures - #18714
Draft
izaac wants to merge 1 commit into
Draft
[backport v2.15.1] [Automation] - Fix imported generic cluster e2e failures#18714izaac wants to merge 1 commit into
izaac wants to merge 1 commit into
Conversation
The tests in the Imported block were failing before they reached anything they were meant to cover. Absorb the cold start of the dynamically imported list component in a before hook, select the registration tab explicitly rather than waiting for the `#registration` fragment that Tabbed only writes as a side effect of picking a default tab, assert the intermediate waiting state before the registration manifest is applied rather than after, move timeouts off `should()` where they were read as the assertion message and onto the commands that yield the element, thread them through `ListRowPo.column` so they survive narrowing a row to a cell, target the import button by its own test id rather than by position in the masthead, navigate to the detail page instead of gating on the create form redirect which is unreliable after an import (see rancher#18712), and assert the table of contents scroll against the inner container the dashboard actually scrolls rather than the window.
Contributor
|
🔄 Auto-Retry Failed Run The Tests workflow failed for the commits below and has been automatically retried.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #18713 to
release-2.15.The commits applied cleanly, so the changes are the same as on master.
Summary
Fixes rancher/qa-tasks#2488
Fixes rancher/qa-tasks#2462
Fixes rancher/qa-tasks#2463
Occurred changes and/or fixed issues
Imported.Genericblock, the three tests were failing before they reached anything they were meant to cover#registrationfragment, the registration tab is now selected explicitlyTechnical notes summary
#registrationis not written by the router, it is a side effect ofTabbedpicking a default tab, which happens once while no tab is active. The registration tab only exists after the registration token resolves, so if the token is slow another tab wins and the fragment never appears. A longer timeout cannot fix that orderingrowWithName()did not carry over tocolumn(), which fell back to the 10s default. Threaded the options through.should()reads its second argument as the assertion message, so timeouts passed there were ignoredwindow.scrollYis always zero hereTesting done
The failures also needed an infrastructure fix, the imported cluster's k3s was advertising its public IP so CoreDNS could never reach the API server and the cluster never went active. That is rancher/qa-infra-automation#159.
With that in place this block goes from 3 failures to a full pass, in under a minute. Validated on this branch, the block passes 4/4 in under a minute.
Checklist
Admin,Standard UserandUser Base